feat(rules): Add no-empty-title rule

[himynameisdave]

Having an empty string as title is pretty useless. This adds a new rule to ensure that tests have real titles.

Resolves #226

---

The following patterns are considered warnings:

describe('', () => {});
describe('foo', () => {
  it('', () => {});
});
it('', () => {});
test('', () => {});
xdescribe('', () => {});
xit('', () => {});
xtest('', () => {});

These patterns would not be considered warnings:

describe('foo', () => {});
describe('foo', () => {
  it('bar', () => {});
});
test('foo', () => {});
it('foo', () => {});
xdescribe('foo', () => {});
xit('foo', () => {});
xtest('foo', () => {});

[SimenB]

Thanks! Can you add it to the main readme? (Prettier handles the formatting in the table)

Also, CI is unhappy since we don't have 100% test coverage. Either add the test cases or delete the code if it doesn't actually do anything :)

[himynameisdave]

@SimenB yes I can add to the README, and yes I can get us to 100% coverage!

[himynameisdave]

@SimenB resolved your comments.

Note the build is still failing, but it is also failing on master.

Let me know when that gets resolved upstream and I'll merge that fix in here. Otherwise just let me know if you have any other comments to address! 👍

[SimenB]

master is fixed, so a rebase/merge should do the trick 🙂

[himynameisdave]

@SimenB resolved the typo, let me know if I need to fix anything else!

[SimenB]

Added a test for template literals - if CI is happy then I'm happy 🙂

[SimenB]

I pushed a failing test, could you fix it?

[himynameisdave]

@SimenB yeah it wasn't handling template literals well.

These cases weren't reporting:

it(``, () => {});
it(`${someVar}`, () => {});

They are now though, so everything should work! Let me know if you need to me change anything else!

[himynameisdave]

whoops my bad!

[SimenB]

thanks!

[SimenB]

🎉 This PR is included in version 22.4.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[garyking]

The rule doesn't seem to work. It needs to be added to index.js right?

[SimenB]

Good point!

[himynameisdave]

Oops my bad!

[SimenB]

Fixed in 22.4.1, thanks for reporting @garyking!

[iamnewton]

Was this rule removed at some point? I don't see it in the docs, nor in the file system and I'm not seeing reference to its removal.

[SimenB]

Merged into valid-title in bb2d09e

[iamnewton]

Thanks @SimenB