feat(whitelist-snapshots): option for whitelisting snapshots #288
Conversation
|
Can someone merge this? Or at least give feedback? |
|
Following #291, also please update the schema for this rule to include the option 🙂 |
… into feature/white-list-snapshots
|
@benmonro looks like you have some leftover code ("jestx") in there, might want to remove that so it's ready when Simen has time for a final review and merge :) |
benmonro
force-pushed
the
feature/white-list-snapshots
branch
from
b3a3b63
to
3a8934d
Compare
|
@jeysal thanks, good catch, merged a branch i didn't mean to. fixed. |
|
Help me @SimenB you're my only hope! |
|
@SimenB I noticed some merges that went in, but this PR got skipped. is there something I'm missing that you'd like to see included here? We really could use this feature. please advise. |
|
@SimenB @jeysal ok guys, I have addressed everything, including Simen's latest comments. Now that Simen approved, can we please please please please merge this? I've been very patient. In the meantime my team is writing large snapshots and we need this desperately. please merge. pretty please... with cherries on top. 😄 |
|
Thanks @SimenB ! |
|
🎉 This PR is included in version 22.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull request adds an option to whitelist snapshots. Since .snap files are generated, if you try to use
//eslint-disable-next-linein a .snap file, the next time any snapshot is updated in that file, all of those comments will be removed. For codebases with a large number of large snapshots, it is useful to be able to grandfather in existing large snapshots, while at the same time not allowing new large snapshots into the code.