Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valid-describe should support describe.each #336

Closed
G-Rath opened this issue Jul 22, 2019 · 6 comments
Closed

valid-describe should support describe.each #336

G-Rath opened this issue Jul 22, 2019 · 6 comments

Comments

@G-Rath
Copy link
Collaborator

G-Rath commented Jul 22, 2019

As per #334, valid-describe currently doesn't support describe.each, instead just bailing out.

@G-Rath
Copy link
Collaborator Author

G-Rath commented Aug 11, 2019

I'm wondering if this should be a separate rule? (valid-describe-each).

Just b/c the domains are nicely encapsulated - otherwise valid-describe is going to get pretty bloated & strung out.

@SimenB
Copy link
Member

SimenB commented Aug 11, 2019

I think conceptually it doesn't make sense to separate them, even though the implementation might be a bit big. But branching inside of it into what's essentially to separate rules can work? Without increasing implementation complexity

@SimenB
Copy link
Member

SimenB commented Nov 7, 2019

It doesn't bail out anymore, it has false positives

@G-Rath
Copy link
Collaborator Author

G-Rath commented Nov 7, 2019

Yeah huh I thought I closed this already 🤷‍♀

@G-Rath G-Rath closed this as completed Nov 7, 2019
@SimenB
Copy link
Member

SimenB commented Nov 7, 2019

False positives is worse than bailing 😛

@G-Rath
Copy link
Collaborator Author

G-Rath commented Nov 7, 2019

False positives is worse than bailing 😛

Well then make an issue 😜

I thought I fixed all the false positives?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants