Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

valid-expect does not work with then - Closes #347 #352

Merged
merged 1 commit into from Jul 25, 2019
Merged

valid-expect does not work with then - Closes #347 #352

merged 1 commit into from Jul 25, 2019

Conversation

yatki
Copy link
Contributor

@yatki yatki commented Jul 25, 2019

resolves #347

@yatki yatki mentioned this pull request Jul 25, 2019
Closed
SimenB
SimenB approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much!

@SimenB SimenB merged commit 0bbfb3a into jest-community:master Jul 25, 2019
@SimenB
Copy link
Member

SimenB commented Jul 25, 2019

🎉 This PR is included in version 22.13.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@yatki
Copy link
Contributor Author

yatki commented Jul 25, 2019

@SimenB actually I added some comments with https://github.com/yatki/eslint-plugin-jest/commit/50dcd02290fa053241217fb3ebfb0eb5ad3b4585 would you like to pull them maybe ?

@SimenB
Copy link
Member

SimenB commented Jul 25, 2019

For sure! Mind opening up a new PR? Some comments explaining what's going on in this rule seems like a great idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

valid-expect does not work with then
2 participants
@yatki @SimenB