methodName: ensure method(node) returns truthy before trying to use return #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
changed the title
SimenB
requested changes
Jul 31, 2019
src/rules/util.js
Outdated
| @@ -87,7 +87,7 @@ export const method = node => node.parent.property; | |||
|
|
|||
| export const method2 = node => node.parent.parent.property; | |||
|
|
|||
| const methodName = node => method(node).name; | |||
| const methodName = node => method(node) && method(node).name; | |||
|
|
|||
| const methodName2 = node => method2(node).name; | |||
There was a problem hiding this comment.
Same here? expect(something).not; or something like that?
There was a problem hiding this comment.
I could do - I don't think it's needed per say b/c all the rules that use it check using method first, but I'll add it in anyway :)
SimenB
approved these changes
Jul 31, 2019
|
🎉 This PR is included in version 22.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #357
It's a simple quick fix, as the underlying problem is fixed by the upcoming ts conversation stuff.