Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ESLint v6 #426

Closed
wareczek opened this issue Oct 5, 2019 · 3 comments
Closed

add support for ESLint v6 #426

wareczek opened this issue Oct 5, 2019 · 3 comments

Comments

@wareczek
Copy link

wareczek commented Oct 5, 2019

No description provided.

@G-Rath
Copy link
Collaborator

G-Rath commented Oct 5, 2019

I assume this is b/c you get deprecation warnings?

This'll be upgraded as part of #410, as it requires us to drop Node 6 support.

@wareczek
Copy link
Author

@SimenB
Copy link
Member

SimenB commented Oct 27, 2019

devDependency doesn't matter for you - it's only local to this repository. The plugin should already support eslint v6 (we use those together at work). it's in our peerDependency range already, so there's nothing for us to do here.

"peerDependencies": {
"eslint": ">=5"
},

unless you're getting some kind of warning or error when using this with eslint 6, I'll close this

@SimenB SimenB closed this as completed Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants