Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:(valid-title): check if node has arguments first #436

Merged
merged 1 commit into from Oct 23, 2019
Merged

fix:(valid-title): check if node has arguments first #436

merged 1 commit into from Oct 23, 2019

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Oct 23, 2019

Fixes #435

@G-Rath G-Rath force-pushed the fix-435/valid-title-error-when-no-arguments branch from 70d5371 to d60b7d9 Compare October 23, 2019 18:59
@G-Rath G-Rath merged commit e961e21 into master Oct 23, 2019
@G-Rath G-Rath deleted the fix-435/valid-title-error-when-no-arguments branch October 23, 2019 19:42
@G-Rath
Copy link
Collaborator Author

G-Rath commented Oct 23, 2019

@SimenB Would be keen to release this - is triggering release bot something I can do, or does it require your private tokens?

@G-Rath G-Rath mentioned this pull request Oct 26, 2019
Merged
@SimenB
Copy link
Member

SimenB commented Oct 26, 2019

just restarting the ci build should work (I just did so)

@G-Rath
Copy link
Collaborator Author

G-Rath commented Oct 26, 2019 •
edited

Oh so releasing done via ci every build? Interesting, but cheers!

I'll explore the configs and see how it's all connected :)

@SimenB
Copy link
Member

SimenB commented Oct 26, 2019

🎉 This PR is included in version 22.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SimenB
Copy link
Member

SimenB commented Oct 26, 2019

every build on master, yes

@SimenB
Copy link
Member

SimenB commented Oct 26, 2019

should explore moving to gh actions 👍

@G-Rath
Copy link
Collaborator Author

G-Rath commented Oct 26, 2019

should explore moving to gh actions 👍

I'd be keen to get in on that action - We've been wanting to explore it at work, but not had an active project to explore it w/.

@SimenB
Copy link
Member

SimenB commented Oct 26, 2019

I'd be keen to get in on that action

hah 😆

@swissspidy swissspidy mentioned this pull request Oct 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[valid-title]: TypeError when no arguments passed to test: Cannot read property 'type' of undefined
2 participants
@G-Rath @SimenB