Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(no-test-callback): don't provide fix for async functions #469

Merged
merged 1 commit into from Nov 8, 2019
Merged

fix(no-test-callback): don't provide fix for async functions #469

merged 1 commit into from Nov 8, 2019

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Nov 7, 2019

Fixes #466

@SimenB could you check that the commit message is correct for triggering a new release?

@G-Rath G-Rath requested a review from SimenB November 7, 2019 19:39
@G-Rath G-Rath mentioned this pull request Nov 7, 2019
Closed
@SimenB
Copy link
Member

SimenB commented Nov 7, 2019 •
edited

It'd trigger a release yeah, just missing coverage 👍

@G-Rath
Copy link
Collaborator Author

G-Rath commented Nov 7, 2019

just missing coverage 👍

:(

Forgot to remove the callback.async check, and then IntelliJ decided to truncate the schemas for all my shelved patches....

@SimenB SimenB merged commit 09111e0 into master Nov 8, 2019
@SimenB SimenB deleted the fix-466 branch November 8, 2019 08:29
github-actions bot pushed a commit that referenced this pull request Nov 8, 2019
@semantic-release-bot
chore(release): 23.0.3 [skip ci]
e82edd8 
## [23.0.3](v23.0.2...v23.0.3) (2019-11-08)

### Bug Fixes

* **no-test-callback:** don't provide fix for `async` functions ([#469](#469)) ([09111e0](09111e0)), closes [#466](#466)
@github-actions
Copy link

github-actions bot commented Nov 8, 2019

🎉 This PR is included in version 23.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB Awaiting requested review from SimenB

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-test-callback autofix can produce invalid code
2 participants
@G-Rath @SimenB