Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a typo in the require-to-throw-message docs #487

Merged
merged 1 commit into from Nov 27, 2019
Merged

Fixing a typo in the require-to-throw-message docs #487

merged 1 commit into from Nov 27, 2019

Conversation

erunion
Copy link
Contributor

@erunion erunion commented Nov 27, 2019

No description provided.

@G-Rath G-Rath merged commit 3526213 into jest-community:master Nov 27, 2019
github-actions bot pushed a commit that referenced this pull request Nov 27, 2019
@semantic-release-bot
chore(release): 23.0.5 [skip ci]
22d890f 
## [23.0.5](v23.0.4...v23.0.5) (2019-11-27)

### Bug Fixes

* typo in the `require-to-throw-message` docs ([#487](#487)) ([3526213](3526213))
@G-Rath
Copy link
Collaborator

G-Rath commented Nov 27, 2019

Probably should have been a doc commit, but nice to have a bug release w/ the chore stuff I did so 🤷‍♂

@SimenB danger seems to be having some troubles of late - can we get that fixed?

@github-actions
Copy link

🎉 This PR is included in version 23.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@erunion
Copy link
Contributor Author

erunion commented Nov 27, 2019

Ah sorry, I made the change directly in Github so commitlint didn't get run.

@erunion erunion deleted the patch-1 branch November 27, 2019 01:38
@G-Rath
Copy link
Collaborator

G-Rath commented Nov 27, 2019

commitlint wouldn't have picked it up anyway :)

The fault technically is mine, as I can re-write the commits on merge via squash, but I'm glad to have the chore changes + updated lock file landed for stability purposes, so no big deal.

@SimenB
Copy link
Member

SimenB commented Nov 27, 2019

@SimenB danger seems to be having some troubles of late - can we get that fixed?

It should hopefully help once we don't have to build it - danger/danger-js#938 & danger/swift#292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-Rath G-Rath G-Rath approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erunion @G-Rath @SimenB