feat(rules): add support for function declaration as test case #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blake-newman
force-pushed
the
blake.newman/add-support-for-function-declaration
branch
from
3eb69ad
to
52b05c8
Compare
G-Rath
requested changes
Jan 6, 2020
blake-newman
force-pushed
the
blake.newman/add-support-for-function-declaration
branch
2 times, most recently
from
6aac2a8
to
55caaed
Compare
|
@G-Rath Thanks for the fast review; i have now updated based on your requested changes and ensured coverage in tests meets 100% |
G-Rath
requested changes
Jan 7, 2020
blake-newman
force-pushed
the
blake.newman/add-support-for-function-declaration
branch
from
55caaed
to
0d11f9a
Compare
G-Rath
requested changes
Jan 8, 2020
Add support for the following test file structure.
```js
test('my test', myTest)
function myTest() {
expect(true).toBe(true)
}
```
Methods that are directly referenced will be ananalyzed for the
following rules `expect-expect` `no-if` `no-test-return-statement`,
`no-try-expect`
blake-newman
force-pushed
the
blake.newman/add-support-for-function-declaration
branch
from
0d11f9a
to
c4f7f87
Compare
|
🎉 This PR is included in version 23.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the following test file structure.
Methods that are directly referenced will be ananalyzed for the
following rules
expect-expectno-ifno-test-return-statement,no-try-expect