Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prefer-to-contain): check that expect argument is defined before use #542

Merged
merged 2 commits into from Mar 6, 2020

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Mar 6, 2020

馃崷

@G-Rath G-Rath force-pushed the check-expect-arg-is-defined branch from 237ee29 to 3abeeee Compare March 6, 2020 00:50
@G-Rath G-Rath force-pushed the check-expect-arg-is-defined branch from 3abeeee to f28ff67 Compare March 6, 2020 00:56
@G-Rath
Copy link
Collaborator Author

G-Rath commented Mar 6, 2020

@SimenB I had to regenerate the lockfile because the tests were failing due to nodejs/node#32107, and then manually revert eslint-plugin-import back in the lock due to import-js/eslint-plugin-import#1655 which meant the Windows tests would fail 馃槵

Just a heads up in case you run into this elsewhere (it's already happened in eslint-plugin-jest-extended).

@G-Rath G-Rath merged commit 56f909b into master Mar 6, 2020
@G-Rath G-Rath deleted the check-expect-arg-is-defined branch March 6, 2020 01:36
github-actions bot pushed a commit that referenced this pull request Mar 6, 2020
## [23.8.2](v23.8.1...v23.8.2) (2020-03-06)

### Bug Fixes

* **prefer-to-contain:** check that expect argument is defined before use ([#542](#542)) ([56f909b](56f909b))
@github-actions
Copy link

github-actions bot commented Mar 6, 2020

馃帀 This PR is included in version 23.8.2 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant