Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should we do in the new major #574

Closed
G-Rath opened this issue May 9, 2020 · 4 comments
Closed

What should we do in the new major #574

G-Rath opened this issue May 9, 2020 · 4 comments

Comments

@G-Rath
Copy link
Collaborator

G-Rath commented May 9, 2020

Just making this meta issue to consolidate what we'd like to land in/around the new major, since we've made some comments in different places:

Depending on time, we could try to do #482.

(I don't think we're in any major rush, since we're not actually blocking anything re jest 26 or eslint 7 - I could be wrong there?)

@SimenB made some comments too:

  • Dropping eslint 5 support (👍)
  • Use the suggestions api for things, such as:
    • toStrictEqual - personally I'm happy with that remaining an autofix, because running your tests should tell you if it's actually changed a behaviour (which is also why I wondered if maybe it should be recommended - it strikes me as a bit like == vs ===?)
    • no-test-callback should use a suggestion as it's dangerous to autofix
  • Renaming no-test-callback to no-done-callback as it's a more accurate name (👍)
@SimenB
Copy link
Member

SimenB commented May 9, 2020

And adding support for hooks (before{All,Each}, after{All,Each}) for that last one.

Nothing else comes to mind, @thymikee @jeysal ideas?

@jeysal
Copy link
Member

jeysal commented Jun 6, 2020

My only ambition for a major would be the recommended ruleset update 🙃 (but as posted over there in the relevant issue, I'd prefer to add like a billion things to it so.... 😅 )

@G-Rath G-Rath pinned this issue Jul 5, 2020
@G-Rath
Copy link
Collaborator Author

G-Rath commented Aug 22, 2020

I've created #649 to track adding support for hooks - are we considering that a breaking feature?

Once I've done #649 I'll rename the rule to no-done-callback.

@SimenB
Copy link
Member

SimenB commented Sep 4, 2020

@SimenB SimenB closed this as completed Sep 4, 2020
@SimenB SimenB unpinned this issue Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants