fix: remove Jasmine globals #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
approved these changes
May 26, 2020
BREAKING CHANGE: Jasmine globals are no marked as such
G-Rath
added a commit
that referenced
this pull request
Jun 20, 2020
* fix: remove Jasmine globals BREAKING CHANGE: Jasmine globals are no marked as such * chore: remove `require` as well * chore: remove `fail` as well Co-authored-by: Gareth Jones <jones258@gmail.com>
G-Rath
added a commit
that referenced
this pull request
Jun 20, 2020
* fix: remove Jasmine globals BREAKING CHANGE: Jasmine globals are no marked as such * chore: remove `require` as well * chore: remove `fail` as well Co-authored-by: Gareth Jones <jones258@gmail.com>
G-Rath
added a commit
that referenced
this pull request
Jun 20, 2020
* fix: remove Jasmine globals BREAKING CHANGE: Jasmine globals are no marked as such * chore: remove `require` as well * chore: remove `fail` as well Co-authored-by: Gareth Jones <jones258@gmail.com>
G-Rath
added a commit
that referenced
this pull request
Jun 21, 2020
* fix: remove Jasmine globals BREAKING CHANGE: Jasmine globals are no marked as such * chore: remove `require` as well * chore: remove `fail` as well Co-authored-by: Gareth Jones <jones258@gmail.com>
G-Rath
added a commit
that referenced
this pull request
Jun 21, 2020
* fix: remove Jasmine globals BREAKING CHANGE: Jasmine globals are no marked as such * chore: remove `require` as well * chore: remove `fail` as well Co-authored-by: Gareth Jones <jones258@gmail.com>
G-Rath
added a commit
that referenced
this pull request
Jun 25, 2020
* fix: remove Jasmine globals BREAKING CHANGE: Jasmine globals are no marked as such * chore: remove `require` as well * chore: remove `fail` as well Co-authored-by: Gareth Jones <jones258@gmail.com>
G-Rath
added a commit
that referenced
this pull request
Jul 26, 2020
* fix: remove Jasmine globals BREAKING CHANGE: Jasmine globals are no marked as such * chore: remove `require` as well * chore: remove `fail` as well Co-authored-by: Gareth Jones <jones258@gmail.com>
G-Rath
added a commit
that referenced
this pull request
Jul 28, 2020
* fix: remove Jasmine globals BREAKING CHANGE: Jasmine globals are no marked as such * chore: remove `require` as well * chore: remove `fail` as well Co-authored-by: Gareth Jones <jones258@gmail.com>
SimenB
added a commit
that referenced
this pull request
Jul 30, 2020
* fix: remove Jasmine globals BREAKING CHANGE: Jasmine globals are no marked as such * chore: remove `require` as well * chore: remove `fail` as well Co-authored-by: Gareth Jones <jones258@gmail.com>
SimenB
added a commit
that referenced
this pull request
Jul 30, 2020
* fix: remove Jasmine globals BREAKING CHANGE: Jasmine globals are no marked as such * chore: remove `require` as well * chore: remove `fail` as well Co-authored-by: Gareth Jones <jones258@gmail.com>
SimenB
added a commit
that referenced
this pull request
Jul 30, 2020
BREAKING CHANGE: Jasmine globals are no marked as such Co-authored-by: Gareth Jones <jones258@gmail.com>
SimenB
added a commit
that referenced
this pull request
Jul 30, 2020
BREAKING CHANGE: Jasmine globals are no marked as such Co-authored-by: Gareth Jones <jones258@gmail.com>
SimenB
added a commit
that referenced
this pull request
Jul 30, 2020
BREAKING CHANGE: Jasmine globals are no marked as such Co-authored-by: Gareth Jones <jones258@gmail.com>
SimenB
added a commit
that referenced
this pull request
Jul 30, 2020
BREAKING CHANGE: Jasmine globals are no marked as such Co-authored-by: Gareth Jones <jones258@gmail.com>
SimenB
added a commit
that referenced
this pull request
Jul 30, 2020
BREAKING CHANGE: Jasmine globals are no marked as such Co-authored-by: Gareth Jones <jones258@gmail.com>
G-Rath
added a commit
that referenced
this pull request
Jul 31, 2020
BREAKING CHANGE: Jasmine globals are no marked as such Co-authored-by: Gareth Jones <jones258@gmail.com>
SimenB
added a commit
that referenced
this pull request
Aug 22, 2020
BREAKING CHANGE: Jasmine globals are no marked as such Co-authored-by: Gareth Jones <jones258@gmail.com>
SimenB
added a commit
that referenced
this pull request
Aug 22, 2020
BREAKING CHANGE: Jasmine globals are no marked as such Co-authored-by: Gareth Jones <jones258@gmail.com>
SimenB
added a commit
that referenced
this pull request
Aug 24, 2020
BREAKING CHANGE: Jasmine globals are no marked as such Co-authored-by: Gareth Jones <jones258@gmail.com>
SimenB
added a commit
that referenced
this pull request
Aug 24, 2020
BREAKING CHANGE: Jasmine globals are no marked as such Co-authored-by: Gareth Jones <jones258@gmail.com>
SimenB
added a commit
that referenced
this pull request
Aug 31, 2020
BREAKING CHANGE: Jasmine globals are no marked as such Co-authored-by: Gareth Jones <jones258@gmail.com>
SimenB
added a commit
that referenced
this pull request
Sep 4, 2020
BREAKING CHANGE: Jasmine globals are no marked as such
SimenB
added a commit
that referenced
this pull request
Sep 4, 2020
BREAKING CHANGE: Jasmine globals are no marked as such
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2020
# [24.0.0](v23.20.0...v24.0.0) (2020-09-04) ### Bug Fixes * **no-large-snapshots:** run on all files regardless of type ([#637](#637)) ([22113db](22113db)), closes [#370](#370) * remove Jasmine globals ([#596](#596)) ([a0e2bc5](a0e2bc5)) * update to typescript-eslint@4 ([1755965](1755965)), closes [#590](#590) ### Code Refactoring * **no-test-callback:** rename rule to `no-done-callback` ([#653](#653)) ([e15a8d1](e15a8d1)) ### Features * **no-done-callback:** support hooks ([#656](#656)) ([3e6cb44](3e6cb44)), closes [#649](#649) [#651](#651) * add `no-conditional-expect` to the recommended ruleset ([40cd89d](40cd89d)) * add `no-deprecated-functions` to the recommended ruleset ([5b2af00](5b2af00)) * add `no-interpolation-in-snapshots` to the recommended ruleset ([3705dff](3705dff)) * add `valid-title` to recommended ruleset ([41f7873](41f7873)) * drop support for node 8 ([#570](#570)) ([6788e72](6788e72)) * set `no-jasmine-globals` to `error` in recommended ruleset ([7080952](7080952)) * **no-large-snapshots:** remove `whitelistedSnapshots` option ([8c1c0c9](8c1c0c9)) ### BREAKING CHANGES * **no-done-callback:** `no-done-callback` will now report hooks using callbacks as well, not just tests * **no-test-callback:** rename `no-test-callback` to `no-done-callback` * recommend `no-conditional-expect` rule * recommend `no-interpolation-in-snapshots` rule * recommend `no-deprecated-functions` rule * recommend `valid-title` rule * recommend erroring for `no-jasmine-globals` rule * **no-large-snapshots:** `no-large-snapshots` runs on all files regardless of type * Jasmine globals are no marked as such * Node 10+ required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should remove
failwhen #595 lands as well.Documented globals: https://jestjs.io/docs/en/api
https://github.com/facebook/jest/blob/eff3eaaad2bde223365da6522cfac7960267fb46/packages/jest-globals/src/index.ts