feat(valid-title): support mustMatch & mustNotMatch options
#608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
support-must-match-option
branch
from
a70a4cc
to
2e755dd
Compare
G-Rath
force-pushed
the
support-must-match-option
branch
from
2e755dd
to
d845372
Compare
G-Rath
changed the title
mustMatch optionmustMatch & mustNotMatch options
G-Rath
force-pushed
the
support-must-match-option
branch
from
d845372
to
6c34c88
Compare
SimenB
approved these changes
Jul 5, 2020
|
🎉 This PR is included in version 23.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thx for the PR, exactly what I need, would be great if we could also add an array of keywords for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #233
Closes #605
I implemented both
mustMatch&mustNotMatchfor the sake of completeness, since RegExp is not good at handling "not" matches.