Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowercase-name rule ignoreTopLevelDescribe option only applies to first describe in file #613

Closed
overlookmotel opened this issue Jun 23, 2020 · 2 comments · Fixed by #614

Comments

@overlookmotel
Copy link

The ignoreTopLevelDescribe option for lowercase-name rule, added in #611, seems to only apply to the first describe block in a file.

e.g. 'Booleans' gets flagged as a rule violation here:

describe('Strings', () => {
  it('are strings', () => {
    expect('abc').toBe('abc');
  });
});

describe('Booleans', () => {
  it('are booleans', () => {
    expect(true).toBe(true);
  });
});
@G-Rath
Copy link
Collaborator

G-Rath commented Jun 23, 2020

Whoops that's my bad - I forgot to decrease the describe counter when going back up the nest 😬

github-actions bot pushed a commit that referenced this issue Jun 23, 2020
## [23.17.1](v23.17.0...v23.17.1) (2020-06-23)

### Bug Fixes

* **lowercase-name:** ignore all top level describes when option is true ([#614](#614)) ([624018a](624018a)), closes [#613](#613)
@github-actions
Copy link

🎉 This issue has been resolved in version 23.17.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants