feat(no-large-snapshots): deprecate whitelistedSnapshots for new name
#632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
rename-no-large-snapshots-property
branch
from
7b2ae7c
to
7e1786a
Compare
G-Rath
force-pushed
the
rename-no-large-snapshots-property
branch
from
7e1786a
to
02eee8a
Compare
SimenB
approved these changes
Jul 30, 2020
|
Yes (thats the plan) and yes - I think we're pretty good to go for the new major - the main thing left is to decide on what rules to make recommended. |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2020
# [23.20.0](v23.19.0...v23.20.0) (2020-07-30) ### Features * **no-large-snapshots:** deprecate `whitelistedSnapshots` for new name ([#632](#632)) ([706f5c2](706f5c2))
|
🎉 This PR is included in version 23.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd be happy to deprecate passing in RegExp instances at the same time if we want to simplify things. I don't use the rule myself so not sure how heavily the RegExp support is used.