Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-conditional-expect): check for expects in catchs on promises #819

Merged
merged 1 commit into from Apr 26, 2021

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Apr 10, 2021

Fixes #818

@G-Rath G-Rath force-pushed the no-conditional-expect-support-catch branch from 1f052e2 to 578268f Compare April 10, 2021 22:27
@manovotny
Copy link

manovotny commented Apr 14, 2021

Love it! ❤️ This looks great to me! 👍

@G-Rath G-Rath merged commit 1fee973 into main Apr 26, 2021
@G-Rath G-Rath deleted the no-conditional-expect-support-catch branch April 26, 2021 00:10
github-actions bot pushed a commit that referenced this pull request Apr 26, 2021
## [24.3.6](v24.3.5...v24.3.6) (2021-04-26)

### Bug Fixes

* **no-conditional-expect:** check for expects in `catch`s on promises ([#819](#819)) ([1fee973](1fee973))
* **valid-expect:** support async `expect` in ternary statements ([#833](#833)) ([7b7a396](7b7a396))
* improve handling of `.each` calls and with tagged literals ([#814](#814)) ([040c605](040c605))
@github-actions
Copy link

🎉 This PR is included in version 24.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should no-conditional-expect prevent Promise catch in tests?
2 participants