fix(valid-expect-in-promise): support awaited promises in arguments #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
valid-expect-in-promise-await-in-args
branch
from
fe55050
to
585dde6
Compare
|
I just realised I've missed a case in my logic: |
This was referenced Oct 11, 2021
|
conflict 🙁 |
G-Rath
force-pushed
the
valid-expect-in-promise-await-in-args
branch
from
7627d57
to
aa6e687
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Oct 11, 2021
## [25.0.3](v25.0.2...v25.0.3) (2021-10-11) ### Bug Fixes * **valid-expect-in-promise:** support awaited promises in arguments ([#936](#936)) ([bd2c33c](bd2c33c))
|
🎉 This PR is included in version 25.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #930
During this also found another bug, and though up two other cases:
awaitwithin an array (which is an extension of this) andexpect(promise).resolves/rejects(which is a bit of a special case but think we should be able to support it easily, and it forms a nice bridge over tovalid-expect, which'll handle ensuring theexpectisawaited).