From 231f901c185124faf5b4f06ded518782f3d79f28 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Wed, 31 Jul 2019 13:42:05 +1200 Subject: [PATCH 1/4] chore(prefer-to-be-null): add test to `prefer-to-be-null` --- src/rules/__tests__/prefer-to-be-null.test.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rules/__tests__/prefer-to-be-null.test.js b/src/rules/__tests__/prefer-to-be-null.test.js index 43fb7f033..91631e8b0 100644 --- a/src/rules/__tests__/prefer-to-be-null.test.js +++ b/src/rules/__tests__/prefer-to-be-null.test.js @@ -17,6 +17,7 @@ ruleTester.run('prefer-to-be-null', rule, { 'expect("a string").not.toMatchSnapshot();', "expect(something).toEqual('a string');", 'expect(null).toBe', + 'expect("something");', ], invalid: [ From 18c866dde4fe7e2190376ad530c99120ad911e91 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Wed, 31 Jul 2019 14:38:25 +1200 Subject: [PATCH 2/4] chore(prefer-to-be-undefined): add test to `prefer-to-be-undefined` --- src/rules/__tests__/prefer-to-be-undefined.test.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rules/__tests__/prefer-to-be-undefined.test.js b/src/rules/__tests__/prefer-to-be-undefined.test.js index 622c408fe..f75767a29 100644 --- a/src/rules/__tests__/prefer-to-be-undefined.test.js +++ b/src/rules/__tests__/prefer-to-be-undefined.test.js @@ -14,6 +14,7 @@ ruleTester.run('prefer-to-be-undefined', rule, { 'expect(something).not.toBe(somethingElse)', 'expect(something).not.toEqual(somethingElse)', 'expect(undefined).toBe', + 'expect("something");', ], invalid: [ From 4c5dd15c32ac6b28ac7b6cf23b0a3690eacc9779 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Wed, 31 Jul 2019 14:39:15 +1200 Subject: [PATCH 3/4] fix: check `method(node)` returns truthy before trying to using results --- src/rules/util.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rules/util.js b/src/rules/util.js index e1edfd291..ca3f5031c 100644 --- a/src/rules/util.js +++ b/src/rules/util.js @@ -87,7 +87,7 @@ export const method = node => node.parent.property; export const method2 = node => node.parent.parent.property; -const methodName = node => method(node).name; +const methodName = node => method(node) && method(node).name; const methodName2 = node => method2(node).name; From b0fb42b018304553de0169f57bd175ad8056cd7c Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Wed, 31 Jul 2019 20:20:49 +1200 Subject: [PATCH 4/4] fix(util): add check to method2 --- src/rules/util.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rules/util.js b/src/rules/util.js index ca3f5031c..a180aa14d 100644 --- a/src/rules/util.js +++ b/src/rules/util.js @@ -89,7 +89,7 @@ export const method2 = node => node.parent.parent.property; const methodName = node => method(node) && method(node).name; -const methodName2 = node => method2(node).name; +const methodName2 = node => method2(node) && method2(node).name; export const argument = node => node.parent.parent.arguments && node.parent.parent.arguments[0];