From bf0f0043bb6dbda72c5a7a7b4e441a577964656b Mon Sep 17 00:00:00 2001 From: Idan Attias Date: Mon, 8 Mar 2021 09:48:58 +0200 Subject: [PATCH] fix(valid-describe): false positive with template describe.each --- src/rules/__tests__/valid-describe.test.ts | 7 +++++++ src/rules/valid-describe.ts | 5 ++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/rules/__tests__/valid-describe.test.ts b/src/rules/__tests__/valid-describe.test.ts index 50eb68c9c..b8781d876 100644 --- a/src/rules/__tests__/valid-describe.test.ts +++ b/src/rules/__tests__/valid-describe.test.ts @@ -50,6 +50,13 @@ ruleTester.run('valid-describe', rule, { if (hasOwnProperty(obj, key)) { } `, + dedent` + describe.each\` + something | other + ${1} | ${2} | + \` + ("$something", ({ something, other }) => { }); + `, ], invalid: [ { diff --git a/src/rules/valid-describe.ts b/src/rules/valid-describe.ts index 84bdf65d3..e07c98666 100644 --- a/src/rules/valid-describe.ts +++ b/src/rules/valid-describe.ts @@ -45,7 +45,10 @@ export default createRule({ create(context) { return { CallExpression(node) { - if (!isDescribe(node)) { + if ( + !isDescribe(node) || + node.callee.type === AST_NODE_TYPES.TaggedTemplateExpression + ) { return; }