Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.8.0 has ansi escape codes #129

Closed
SimenB opened this issue May 7, 2020 · 4 comments · Fixed by #173
Closed

0.8.0 has ansi escape codes #129

SimenB opened this issue May 7, 2020 · 4 comments · Fixed by #173
Assignees
@thymikee

Comments

@SimenB
Copy link
Member

SimenB commented May 7, 2020 •
edited

image

I don't think we want this?

Makes for a very weird diff when seeing it in a terminal which respects these characters
image
@alistairjcbrown
Copy link
Contributor

@SimenB You beat me by a couple of minutes! 😁(#130) - looks like it's because these colors aren't controlled by the passed options in jest-diff? - https://github.com/facebook/jest/blob/4bd3d4a05999170f423f7050d4e0537648499e88/packages/jest-diff/src/constants.ts#L10-L11

@SimenB
Copy link
Member Author

SimenB commented May 7, 2020

@alistairjcbrown PR to Jest so it respects that option is very much welcome 🙂

/cc @pedrottimark

@thymikee thymikee mentioned this issue May 7, 2020
Closed
@alistairjcbrown alistairjcbrown mentioned this issue May 7, 2020
Merged
@alistairjcbrown
Copy link
Contributor

PR up against the Jest repo: jestjs/jest#9997

@SimenB
Copy link
Member Author

SimenB commented Jun 23, 2020

26.1.0 out

alistairjcbrown added a commit to alistairjcbrown/snapshot-diff that referenced this issue Jun 24, 2020
@alistairjcbrown
Update jest-diff to remove colors from no diff message
30fd0b0 
Updates to the latest jest-diff which now supports removing color codes
from "no visual difference" message. A test has been added to confirm
this and prevent regressions in the future.

Fixes jest-community#129
@alistairjcbrown alistairjcbrown mentioned this issue Jun 24, 2020
Merged
alistairjcbrown added a commit to alistairjcbrown/snapshot-diff that referenced this issue Jun 25, 2020
@alistairjcbrown
Update jest-diff to remove colors from no diff message
f70d915 
Updates to the latest jest-diff which now supports removing color codes
from "no visual difference" message. A test has been added to confirm
this and prevent regressions in the future. All jest packages in use
have been updated as part of this commit.

Fixes jest-community#129
thymikee pushed a commit that referenced this issue Jun 28, 2020
@alistairjcbrown
Update jest-diff to remove colors from no diff message (#173)
39f392c 
Updates to the latest jest-diff which now supports removing color codes
from "no visual difference" message. A test has been added to confirm
this and prevent regressions in the future. All jest packages in use
have been updated as part of this commit.

Fixes #129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thymikee thymikee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update jest-diff to remove colors from no diff message alistairjcbrown/snapshot-diff
3 participants
@alistairjcbrown @SimenB @thymikee