From 1c3565f6e5d6a8e987417f688004f340d9bfcb72 Mon Sep 17 00:00:00 2001 From: Mitchell Hentges <110673802+mitchhentgesspotify@users.noreply.github.com> Date: Tue, 8 Nov 2022 15:00:42 +0100 Subject: [PATCH] Defer creation of cache directory (#13420) --- CHANGELOG.md | 2 ++ .../jest-transform/src/ScriptTransformer.ts | 18 ++++++------------ 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 055d9914cf63..5175c390dbbb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,8 @@ ### Performance +- `[jest-transform]` Defer creation of cache directory [#13420](https://github.com/facebook/jest/pull/13420) + ## 29.3.0 ### Features diff --git a/packages/jest-transform/src/ScriptTransformer.ts b/packages/jest-transform/src/ScriptTransformer.ts index 82df9931f7fa..c1d12d8deef9 100644 --- a/packages/jest-transform/src/ScriptTransformer.ts +++ b/packages/jest-transform/src/ScriptTransformer.ts @@ -207,10 +207,7 @@ class ScriptTransformer { ); } - private _createFolderFromCacheKey( - filename: string, - cacheKey: string, - ): string { + private _createCachedFilename(filename: string, cacheKey: string): string { const HasteMapClass = HasteMap.getStatic(this._config); const baseCacheDir = HasteMapClass.getCacheFilePath( this._config.cacheDirectory, @@ -223,12 +220,7 @@ class ScriptTransformer { const cacheFilenamePrefix = path .basename(filename, path.extname(filename)) .replace(/\W/g, ''); - const cachePath = slash( - path.join(cacheDir, `${cacheFilenamePrefix}_${cacheKey}`), - ); - createDirectory(cacheDir); - - return cachePath; + return slash(path.join(cacheDir, `${cacheFilenamePrefix}_${cacheKey}`)); } private _getFileCachePath( @@ -238,7 +230,7 @@ class ScriptTransformer { ): string { const cacheKey = this._getCacheKey(content, filename, options); - return this._createFolderFromCacheKey(filename, cacheKey); + return this._createCachedFilename(filename, cacheKey); } private async _getFileCachePathAsync( @@ -248,7 +240,7 @@ class ScriptTransformer { ): Promise { const cacheKey = await this._getCacheKeyAsync(content, filename, options); - return this._createFolderFromCacheKey(filename, cacheKey); + return this._createCachedFilename(filename, cacheKey); } private _getTransformPath(filename: string) { @@ -504,6 +496,7 @@ class ScriptTransformer { }); } + createDirectory(path.dirname(cacheFilePath)); return this._buildTransformResult( filename, cacheFilePath, @@ -568,6 +561,7 @@ class ScriptTransformer { }); } + createDirectory(path.dirname(cacheFilePath)); return this._buildTransformResult( filename, cacheFilePath,