From fbbf15a2c405df5d8c29a802aa219a9478ad5092 Mon Sep 17 00:00:00 2001 From: Ian VanSchooten Date: Tue, 8 Jun 2021 22:13:22 -0400 Subject: [PATCH] Fix linting errors --- packages/jest-resolve/src/__tests__/resolveAsync.test.ts | 8 ++++---- packages/jest-resolve/src/defaultResolver.ts | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/jest-resolve/src/__tests__/resolveAsync.test.ts b/packages/jest-resolve/src/__tests__/resolveAsync.test.ts index 40a66a84b7a2..40e2097ff01d 100644 --- a/packages/jest-resolve/src/__tests__/resolveAsync.test.ts +++ b/packages/jest-resolve/src/__tests__/resolveAsync.test.ts @@ -89,12 +89,12 @@ describe('findNodeModuleAsync', () => { userResolverAsync.mockImplementation(() => Promise.resolve('module')); const newPath = await ResolverAsync.findNodeModuleAsync('test', { + asyncResolver: require.resolve('../__mocks__/userResolverAsync'), basedir: '/', browser: true, extensions: ['js'], moduleDirectory: ['node_modules'], paths: ['/something'], - asyncResolver: require.resolve('../__mocks__/userResolverAsync'), }); expect(newPath).toBe('module'); @@ -119,8 +119,8 @@ describe('findNodeModuleAsync', () => { ); await ResolverAsync.findNodeModuleAsync('test', { - basedir: '/', asyncResolver: require.resolve('../__mocks__/userResolverAsync'), + basedir: '/', }); expect(mockResolveSync).toHaveBeenCalledWith( @@ -230,11 +230,12 @@ describe('resolveModuleAsync', () => { }); describe('getMockModuleAsync', () => { - it.only('is possible to use custom resolver to resolve deps inside mock modules with moduleNameMapper', async () => { + it('is possible to use custom resolver to resolve deps inside mock modules with moduleNameMapper', async () => { userResolverAsync.mockImplementation(() => Promise.resolve('module')); const moduleMap = ModuleMap.create('/'); const resolver = new ResolverAsync(moduleMap, { + asyncResolver: require.resolve('../__mocks__/userResolverAsync'), extensions: ['.js'], moduleNameMapper: [ { @@ -242,7 +243,6 @@ describe('getMockModuleAsync', () => { regex: /(.*)/, }, ], - asyncResolver: require.resolve('../__mocks__/userResolverAsync'), } as ResolverConfig); const src = require.resolve('../'); diff --git a/packages/jest-resolve/src/defaultResolver.ts b/packages/jest-resolve/src/defaultResolver.ts index a46fa8fc495e..f7967f9e0591 100644 --- a/packages/jest-resolve/src/defaultResolver.ts +++ b/packages/jest-resolve/src/defaultResolver.ts @@ -10,7 +10,6 @@ import pnpResolver from 'jest-pnp-resolver'; import {AsyncOpts, SyncOpts, sync as resolveSync} from 'resolve'; import type {Config} from '@jest/types'; import {tryRealpath} from 'jest-util'; - // QUESTION: What is a better way to import this? const resolveAsync = require('resolve/lib/async');