Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup TODOs on getConsoleOutput signature #10112

Closed
ychi opened this issue Jun 1, 2020 · 2 comments
Closed

Cleanup TODOs on getConsoleOutput signature #10112

ychi opened this issue Jun 1, 2020 · 2 comments
Milestone
Jest 27

Comments

@ychi
Copy link
Contributor

ychi commented Jun 1, 2020

Some parameter modifications are added to TODOs to avoid breaking change, for example, moving root: string to config and taking GlobalConfig as a mandatory one. It will be great if they can be addressed in version 27.

Link to the source file: https://github.com/facebook/jest/blob/28b83378e7879d46c3e10288765f67ea2e40a400/packages/jest-console/src/getConsoleOutput.ts#L18
@ychi ychi mentioned this issue Jun 1, 2020
Merged
@SimenB SimenB added this to the Jest 27 milestone Jun 1, 2020
@ychi ychi mentioned this issue Jun 4, 2020
Merged
@SimenB
Copy link
Member

SimenB commented Dec 5, 2020

Done in #10126

@SimenB SimenB closed this as completed Dec 5, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Jest 27
Development

No branches or pull requests
2 participants
@SimenB @ychi