Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for ignorePattern as function in jest-haste-map #10342

Closed
SimenB opened this issue Jul 31, 2020 · 5 comments · Fixed by #10348
Closed

Remove support for ignorePattern as function in jest-haste-map #10342

SimenB opened this issue Jul 31, 2020 · 5 comments · Fixed by #10348
Labels
good first issue Help Wanted

Comments

@SimenB
Copy link
Member

SimenB commented Jul 31, 2020

It has been deprecated for 3 years - let's remove it for Jest 27.

Should essentially just be deleting these lines - possibly deleting some tests as well?

https://github.com/facebook/jest/blob/ca8bf7c8b7a6f295712250c0867e813a8ef8cc85/packages/jest-haste-map/src/index.ts#L263-L273
@komtaki
Copy link
Contributor

komtaki commented Jul 31, 2020

Hello,
Mind if I give it a try as my first issue?

@SimenB
Copy link
Member Author

SimenB commented Jul 31, 2020

Sure, go for it!

@komtaki komtaki mentioned this issue Jul 31, 2020
Merged
@tri97nguyen
Copy link

@SimenB Hi, it seems like komtaki solved this issue. Could you close it? Leaving it open confused beginners (which was me)

@SimenB
Copy link
Member Author

SimenB commented Sep 27, 2020

Sure - tracked in #10348

@SimenB SimenB closed this as completed Sep 27, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Help Wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(jest-haste-map): remove support for ignorePattern as function
3 participants
@SimenB @tri97nguyen @komtaki