Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor callAsyncCircusFn #10627

Closed
flozender opened this issue Oct 13, 2020 · 8 comments 路 Fixed by #10629
Closed

Refactor callAsyncCircusFn #10627

flozender opened this issue Oct 13, 2020 · 8 comments 路 Fixed by #10629

Comments

@flozender
Copy link
Contributor

flozender commented Oct 13, 2020

馃殌 Feature Proposal

Refactor callAsyncCircusFn to use just testOrHook instead of fn and asyncError. Also, clean up the stack trace.

Motivation

See discussion: here and here.

@flozender
Copy link
Contributor Author

I'd like to take this up!

@SimenB
Copy link
Member

SimenB commented Oct 13, 2020

Please do! If possible converting to async-await instead of .then and .catch would be awesome as well

@flozender
Copy link
Contributor Author

I can take it up as soon as #10624 is ready!

@SimenB
Copy link
Member

SimenB commented Oct 13, 2020

Note that #10624 won't be merged until we start landing changes for Jest 27 as it's a breaking change

@flozender
Copy link
Contributor Author

So will we hold on until then? Because I need testOrHook from #10624 to make the changes needed!

@SimenB
Copy link
Member

SimenB commented Oct 13, 2020

I'd prefer to do this one sooner rather than later as it's not breaking. I think a good approach is just to add testOrHook in a new PR then we can rebase #10624 afterwards (which will also reduce its diff, which is always nice 馃檪)

@flozender
Copy link
Contributor Author

Sounds good. I'll get on it.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants