Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magenta color used for snapshot diffing is nearly unreadable in Git Bash on Windows #11622

Closed
ek68794998 opened this issue Jun 30, 2021 · 4 comments

Comments

@ek68794998
Copy link

馃悰 Bug Report

In the Bash terminal, snapshot diff text is nearly unreadable compared to other consoles.

To Reproduce

Steps to reproduce the behavior:

  • Run a snapshot test that results in a failure (w/ diff).

The outputted text, per the conclusion of #5430 and #9132, is a purple-on-magenta and blue-on-white combination. In PowerShell, this looks great:
image

But in Bash, it's essentially unreadable:
image

Even using Chalk's FORCE_COLOR= with values of 1, 2, and 3, there's no change in Bash.

Expected behavior

The diff text should be readable in all consoles, or at the very least, there should be a setting to do something like "only show black text on colored backgrounds" for readability.

Link to repl or repo (highly encouraged)

I'm unable to log in to repl.it to make a repro... I can put one together if needed, but any failing expect().toMatchSnapshot() test would work.

envinfo

  System:
    OS: Windows 10 10.0.19041
    CPU: (24) x64 AMD Ryzen 9 3900X 12-Core Processor
  Binaries:
    Node: 12.22.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.5 - ~\.yarn\bin\yarn.CMD
    npm: 6.14.12 - C:\Program Files\nodejs\npm.CMD
  npmPackages:
    jest: ^26.6.3 => 26.6.3
@TheJaredWilcurt
Copy link

Duplicate. #9459

@github-actions
Copy link

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Feb 17, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2023
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants