Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: --workerIdleMemoryLimit doesn't work with --maxWorkers 1 #13792

Closed
benjaminjkraft opened this issue Jan 19, 2023 · 4 comments
Closed

[Bug]: --workerIdleMemoryLimit doesn't work with --maxWorkers 1 #13792

benjaminjkraft opened this issue Jan 19, 2023 · 4 comments

Comments

@benjaminjkraft
Copy link
Contributor

Version

29.3.1

Steps to reproduce

Run a bunch of tests with --maxWorkers 1 --workerIdleMemoryLimit 1kb --logHeapUsage. Memory usage will go up way beyond 1kb.

Expected behavior

I expect the worker to be restarted after every test with a low worker idle memory limit. Obviously this doesn't work with --runInBand but with --maxWorkers 1 it should!

Actual behavior

The worker is never restarted.

Additional context

It looks like #13168 and/or #13171 were proposed to fix this, but neither was merged.

Environment

System:
    OS: macOS 13.1
    CPU: (10) x64 Apple M1 Max
  Binaries:
    Node: 16.17.1 - /nix/store/fyaisfdhkviz6sb628qxlmy5wcasqfhq-nodejs-16.17.1/bin/node
    npm: 8.12.1 - ~/.local/bin/npm
  npmPackages:
    jest: 29.3.1 => 29.3.1 

(also in our CI env which is linux on CircleCI)
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Feb 18, 2023
@phawxby
Copy link
Contributor

phawxby commented Feb 27, 2023

This is probably solved by #13846

@github-actions github-actions bot removed the Stale label Feb 27, 2023
@benjaminjkraft
Copy link
Contributor Author

Sure looks like it, thanks!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants