Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Update deprecated subdependencies: abab@2.0.6, domexception@4.0.0 in @jest/types #15027

Open
avetalia opened this issue Apr 14, 2024 · 1 comment

Comments

@avetalia
Copy link

🚀 Feature Proposal

Update deprecated dependencies in @jest/types:
abab@2.0.6, domexception@4.0.0

https://www.npmjs.com/package/abab
Author message:
"Use your platform's native atob() and btoa() methods instead"

https://www.npmjs.com/package/domexception
Author message:
Use your platform's native DOMException instead

Motivation

Warn message:
2 deprecated subdependencies found: abab@2.0.6, domexception@4.0.0

Example

No response

Pitch

n/a

@G-Rath
Copy link
Contributor

G-Rath commented Apr 17, 2024

In v29.7.0 these are bring brought in by jest-environment-jsdom through jsdom:

└─┬ jest-environment-jsdom@29.7.0
  └─┬ jsdom@20.0.3
    ├── abab@2.0.6
    ├─┬ data-urls@3.0.2
    │ └── abab@2.0.6 deduped
    └── domexception@4.0.0
``

and I'm not seeing any direct references to those packages in the Jest codebase so I'm pretty sure they're being brought in by nested dependencies which means this isn't really something directly addressable by Jest.

Note that most likely reason that packages have not moved off such packages is because of Node version support - both `atob` and `btoa` were introduced in Node v16, and `DOMException` was introduced in Node v17; while v16 is no longer in-life it's still supported by a lot of packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants