Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail if describe returns a value #8074

Closed
jeysal opened this issue Mar 7, 2019 · 5 comments 路 Fixed by #10947
Closed

Fail if describe returns a value #8074

jeysal opened this issue Mar 7, 2019 · 5 comments 路 Fixed by #10947
Labels
馃殌 Feature Request
Milestone
Jest 27

Comments

@jeysal
Copy link
Contributor

jeysal commented Mar 7, 2019

馃殌 Feature Proposal

#7852 added warnings if describe returns something, with a special warning if it's a promise to save users from defining its in an async describe block function.
In the next major, Jest should fail the test with an error containing those messages instead of just warning.
@SimenB SimenB added this to the Jest 25 milestone Mar 7, 2019
@SimenB
Copy link
Member

SimenB commented Jan 23, 2020

Forgot this 馃槢

@jeysal
Copy link
Contributor Author

jeysal commented Jan 23, 2020

There were lots of things in the 25 milestone for which I think we didn't consider if they should have went into the release 馃槃 I renamed the milestone to Jest 26

@SimenB
Copy link
Member

SimenB commented Jan 23, 2020

heh, yeah. The timeline went away from us.

I renamed the milestone to Jest 26

Good call 馃憤

@cpojer cpojer modified the milestones: Jest 26, High priority future May 2, 2020
@SimenB SimenB modified the milestones: High priority future, Jest 27 May 3, 2020
@SimenB
Copy link
Member

SimenB commented Dec 5, 2020

@jeysal up for sending a PR implementing this?

@jeysal jeysal mentioned this issue Dec 13, 2020
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
馃殌 Feature Request
Projects
None yet
Milestone
Jest 27
Development

Successfully merging a pull request may close this issue.

feat(jest-circus,jest-jasmine2): throw when describe returns a value jeysal/jest
3 participants
@cpojer @SimenB @jeysal