You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the Babel options sanitisation not change in a minor version
(or if this is seen as an internal implementation detail that we shouldn't have been replying upon) for the Jest changelog to perhaps mention the change
Many thanks :-)
The text was updated successfully, but these errors were encountered:
Aha, that's where it was from! The typings yelled at us and I couldn't find cacheDirectory by grepping in Babel's code base, so I just removed it.
Wanna send a PR adding it back? Even though I don't think it's Jest's job to filter out non-valid options to babel, it doesn't hurt. And we shouldn't stop doing it in a minor
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.
馃挜 Regression Report
After updating to the v24.3.0 minor release, our tests started failing with:
This appears to be due to the change here (CC @SimenB):
https://github.com/facebook/jest/pull/7862/files#diff-ad0be0b5e1f4711c408a42bdbea512bcL42
The reason
cacheDirectory
was present is that we were passing the Babel config used forbabel-loader
as-is:https://github.com/neutrinojs/neutrino/blob/97781fd69dbf01be33a07687670a064395a92a6b/packages/jest/src/index.js#L21-L25
https://github.com/neutrinojs/neutrino/blob/97781fd69dbf01be33a07687670a064395a92a6b/packages/jest/src/transformer.js
In the meantime we've added filtering of
cacheDirectory
(neutrinojs/neutrino/pull/1314).Last working version
Worked up to version: v24.1.0
Stopped working in version: v24.3.0
To Reproduce
Trigger a Travis build on https://github.com/neutrinojs/neutrino revision
97781fd69dbf01be33a07687670a064395a92a6b
(which is before neutrinojs/neutrino/pull/1314).Expected behavior
That either:
Many thanks :-)
The text was updated successfully, but these errors were encountered: