Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license of some modules #8666

Closed
luisapace opened this issue Jul 9, 2019 · 8 comments · Fixed by #8783
Closed

license of some modules #8666

luisapace opened this issue Jul 9, 2019 · 8 comments · Fixed by #8783
Assignees

Comments

@luisapace
Copy link

luisapace commented Jul 9, 2019

Hi, my team would use jest-circus, jest-core, jest-runtime, jest-cli (all 24.8.0) and to approve that I've to verify all its licenses.

Now I've seen that some modules (i.e.
image
image
image
)
show this header:
*_ This source code is licensed under the BSD-style license found in the

LICENSE file in the root directory of this source tree. An additional grant
of patent rights can be found in the PATENTS file in the same directory._**

but in the root directory of the source I cannot see any BSD and PATENT license files.

Could you please clarify me what are the licenses?

Thanks for your support on this.

@pedrottimark
Copy link
Contributor

@cpojer Is it okay to replace any obsolete comments with current license comment:

/**
 * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

@cpojer
Copy link
Member

cpojer commented Jul 10, 2019

Yes

@SimenB
Copy link
Member

SimenB commented Jul 10, 2019

@pedrottimark can you ensure https://github.com/facebook/jest/blob/a501718b80b8b5fbfa3baed1c4fe88fe67b4b062/scripts/checkCopyrightHeaders.js complains about the dated headers?

@pedrottimark pedrottimark self-assigned this Jul 10, 2019
@pedrottimark
Copy link
Contributor

@SimenB The 11 files with obsolete license info match the copyright line

157 files fail if I change the criterion to the following four lines:

 * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.

For example:

  • scripts/checkCopyrightHeaders.js lacks a period at end of its copyright line but you will laugh how long it took me to understand why it has been passing: includes the search string :)
  • website/static/css/custom.css has only copyright line but not license sentence

I am willing to go either way:

  • Fix 11 files and keep current criterion
  • Fix 157 files and upgrade to more complete and specific criterion

@arturrz
Copy link

arturrz commented Aug 14, 2019

Have you done anything about this? There might not be compliance issues between MIT and BSD-style but it can be misleading while making Open Source Compliance review. It's always good to encourage such good practices when developing open source projects.
;)

@pedrottimark
Copy link
Contributor

@luisapace Yes, thank y’all for finding this problem. /cc @arturrz

In #8783 and related chore #8815

  • replaced obsolete sentence about BSD with correct MIT license in 10 files
  • added missing sentence about MIT license to copyright comment in more than 100 files

So it has been fixed in the repo, although there has not been a new minor version yet

@AbhaysinghBhosale
Copy link

anyone have ideas that why all child directory and parent DIR don't have License.
I checked in node_modules/@jest - many child and parent DIR don't have License added.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants