Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Jest repo need .gitattributes file? #8788

Closed
pedrottimark opened this issue Aug 6, 2019 · 2 comments · Fixed by #8809
Closed

Does Jest repo need .gitattributes file? #8788

pedrottimark opened this issue Aug 6, 2019 · 2 comments · Fixed by #8809

Comments

@pedrottimark
Copy link
Contributor

Possible chore

The first solution for #8783 with multiline string copyright and license criterion failed for:

  • packages/expect/src/__tests__/__arbitraries__/sharedSettings.ts
  • packages/expect/src/__tests__/matchers-toContain.property.test.ts
  • packages/expect/src/__tests__/matchers-toContainEqual.property.test.ts
  • packages/expect/src/__tests__/matchers-toEqual.property.test.ts
  • packages/expect/src/__tests__/matchers-toStrictEqual.property.test.ts

because they have CRLF instead of LF for line ending

Nicolas probably assumed that Jest has per-repository settings, but it does not

The only other files that I found in the repo are images or in node_modules subdirectories

For comparison, the React repo has .gitattributes which consists of:

* text=auto

If there is a need in the future for e2e or examples to test behavior on Windows (for examples, snapshot files) then it is possible to add specific exceptions, true?

@jeysal
Copy link
Contributor

jeysal commented Aug 11, 2019

Opened #8809 to resolve the endings issue (not with gitattributes, but with proper config for existing tooling)

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants