Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to fsevent v2 - Node 13 support #9191

Closed
t-ricci-enhancers opened this issue Nov 16, 2019 · 11 comments · Fixed by #9215
Closed

Upgrade to fsevent v2 - Node 13 support #9191

t-ricci-enhancers opened this issue Nov 16, 2019 · 11 comments · Fixed by #9215

Comments

@t-ricci-enhancers
Copy link

t-ricci-enhancers commented Nov 16, 2019

npm WARN deprecated fsevents@1.2.9: One of your dependencies needs to upgrade to fsevents v2: 1) Proper nodejs v10+ support 2) No more fetching binaries from AWS, smaller package size

Using node version 13 it doesn't even build (I'm on Catalina)

@SimenB
Copy link
Member

SimenB commented Nov 16, 2019

I'm hoping to offload this to sane amasad/sane#130 (comment), but we might need to update here

@milesj
Copy link

milesj commented Nov 20, 2019

fsevents v2 also unblocks local Node v12 on OSX, so this change would be super beneficial.

@SimenB
Copy link
Member

SimenB commented Nov 20, 2019

it actually seems pretty trivial to upgrade

@SimenB
Copy link
Member

SimenB commented Nov 20, 2019

@milesj you can use watchman which is faster with Jest to be unblocked

@milesj
Copy link

milesj commented Nov 20, 2019

The issue was jest-haste-map was installing fsevents v1, which blocked usage of Node v12 on OSX since it can't compile the binaries. I'll hold out until the fsevents v2 lands in the next release.

@mbpmohsen
Copy link

hi
I using npm in laravel can you help me this error?

@aaalsubaie
Copy link

the warning still exists!
jest "24.9.0"
jest-haste-map: "^24.9.0"

@benjamn
Copy link
Contributor

benjamn commented Jan 2, 2020

I believe this will be fixed by #9215 once a new version of jest-haste-map is released: #9215 (comment)

Update: in the meantime, I was able to fix the problem by running npm i fsevents@latest in my project, which seems to prevent npm from installing the older optional dependency within jest-haste-map/node_modules.

@banerRana
Copy link

by running npm i fsevents@latest on windows for solving the following issue
"$ npm install
npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2."

led to

"npm ERR! notsup Unsupported platform for fsevents@2.2.1: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm ERR! notsup Valid OS: darwin
npm ERR! notsup Valid Arch: any
npm ERR! notsup Actual OS: win32
npm ERR! notsup Actual Arch: x64
"

does fsevents for winows platform does not exist

@SimenB
Copy link
Member

SimenB commented Jan 4, 2021

You can ignore the warning, fsevents is not used via sane, so the old dep doesn't matter (sane is removed entirely in jest@next)

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants