From 0667caafb0d5d7d3ecdda67b826a3a869e7f5257 Mon Sep 17 00:00:00 2001 From: Wojciech Maj Date: Mon, 19 Oct 2020 17:28:55 +0200 Subject: [PATCH 1/2] Remove recursiveBlacklist option from jest-validate --- packages/jest-config/src/normalize.ts | 2 +- .../src/__tests__/validate.test.ts | 34 ------------------- packages/jest-validate/src/types.ts | 1 - packages/jest-validate/src/validate.ts | 16 +++------ 4 files changed, 5 insertions(+), 48 deletions(-) diff --git a/packages/jest-config/src/normalize.ts b/packages/jest-config/src/normalize.ts index fcd19c4db403..3c07371b2b70 100644 --- a/packages/jest-config/src/normalize.ts +++ b/packages/jest-config/src/normalize.ts @@ -494,7 +494,7 @@ export default function normalize( comment: DOCUMENTATION_NOTE, deprecatedConfig: DEPRECATED_CONFIG, exampleConfig: VALID_CONFIG, - recursiveBlacklist: [ + recursiveDenylist: [ 'collectCoverageOnlyFrom', // 'coverageThreshold' allows to use 'global' and glob strings on the same // level, there's currently no way we can deal with such config diff --git a/packages/jest-validate/src/__tests__/validate.test.ts b/packages/jest-validate/src/__tests__/validate.test.ts index e241c7140261..b816a56ad347 100644 --- a/packages/jest-validate/src/__tests__/validate.test.ts +++ b/packages/jest-validate/src/__tests__/validate.test.ts @@ -101,40 +101,6 @@ test.each([ }, ); -test('respects recursiveBlacklist', () => { - const warn = console.warn; - console.warn = jest.fn(); - const config = { - something: { - nested: { - some_random_key: 'value', - some_random_key2: 'value2', - }, - }, - }; - const exampleConfig = { - something: { - nested: { - test: true, - }, - }, - }; - - validate(config, {exampleConfig}); - - expect(console.warn).toBeCalled(); - - console.warn.mockReset(); - - validate(config, { - exampleConfig, - recursiveBlacklist: ['something.nested'], - }); - - expect(console.warn).not.toBeCalled(); - console.warn = warn; -}); - test('respects recursiveDenylist', () => { const warn = console.warn; console.warn = jest.fn(); diff --git a/packages/jest-validate/src/types.ts b/packages/jest-validate/src/types.ts index aba81d819edc..4c8f6beacda7 100644 --- a/packages/jest-validate/src/types.ts +++ b/packages/jest-validate/src/types.ts @@ -34,7 +34,6 @@ export type ValidationOptions = { ) => void; exampleConfig: Record; recursive?: boolean; - recursiveBlacklist?: Array; recursiveDenylist?: Array; title?: Title; unknown?: ( diff --git a/packages/jest-validate/src/validate.ts b/packages/jest-validate/src/validate.ts index 7c4089ba0131..108b49e7b884 100644 --- a/packages/jest-validate/src/validate.ts +++ b/packages/jest-validate/src/validate.ts @@ -70,11 +70,7 @@ const _validate = ( options.error(key, config[key], exampleConfig[key], options, path); } } else if ( - shouldSkipValidationForPath( - path, - key, - options.recursiveDenylist || options.recursiveBlacklist, - ) + shouldSkipValidationForPath(path, key, options.recursiveDenylist) ) { // skip validating unknown options inside blacklisted paths } else { @@ -85,12 +81,8 @@ const _validate = ( if ( options.recursive && !Array.isArray(exampleConfig[key]) && - (options.recursiveDenylist || options.recursiveBlacklist) && - !shouldSkipValidationForPath( - path, - key, - options.recursiveDenylist || options.recursiveBlacklist, - ) + options.recursiveDenylist && + !shouldSkipValidationForPath(path, key, options.recursiveDenylist) ) { _validate(config[key], exampleConfig[key], options, [...path, key]); } @@ -112,7 +104,7 @@ const validate = ( // Preserve default denylist entries even with user-supplied denylist const combinedDenylist: Array = [ ...(defaultConfig.recursiveDenylist || []), - ...(options.recursiveDenylist || options.recursiveBlacklist || []), + ...(options.recursiveDenylist || []), ]; const defaultedOptions: ValidationOptions = Object.assign({ From 47b09df16f632b52f23060ff5a186cd305b9b71d Mon Sep 17 00:00:00 2001 From: Wojciech Maj Date: Mon, 19 Oct 2020 17:35:21 +0200 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 94312007da65..1c36db2e880a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,8 @@ ### Chore & Maintenance +- `[jest-validate]` [**BREAKING**] Remove `recursiveBlacklist ` option in favor of previously introduced `recursiveDenylist` ([#10650](https://github.com/facebook/jest/pull/10650)) + ### Performance ## 26.6.0