From 737a6705576e2048b47d1713b63e35e6bbc7d4ed Mon Sep 17 00:00:00 2001 From: Vladimir Razuvaev Date: Tue, 31 Aug 2021 02:56:44 +0700 Subject: [PATCH 1/2] fix: return correct type from process.send stub The `process.send` stub created by Jest always returns `undefined` but Node actually always returns `boolean` value from `process.send` (see types [1](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/7f660501fbf2e57f885cabf9723aa57c8bfe4f47/types/node/process.d.ts#L1268-L1275) and [2](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/7f660501fbf2e57f885cabf9723aa57c8bfe4f47/types/node/child_process.d.ts#L447-L449), as well as [Node docs](https://nodejs.org/dist/latest-v14.x/docs/api/process.html#process_process_send_message_sendhandle_options_callback)) By default, it returns `true` and only returns `false` when the IPC message is buffered or the child process had already exited, see [related docs on child_process](https://nodejs.org/dist/latest-v14.x/docs/api/child_process.html#child_process_subprocess_send_message_sendhandle_options_callback) --- packages/jest-util/src/createProcessObject.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/jest-util/src/createProcessObject.ts b/packages/jest-util/src/createProcessObject.ts index 83d8774ad070..462f3f812ce7 100644 --- a/packages/jest-util/src/createProcessObject.ts +++ b/packages/jest-util/src/createProcessObject.ts @@ -110,7 +110,7 @@ export default function (): NodeJS.Process { } newProcess.env = createProcessEnv(); - newProcess.send = () => {}; + newProcess.send = () => true; Object.defineProperty(newProcess, 'domain', { get() { From 5a6d3db42c0acef6fb23c96ee46598700cd7e236 Mon Sep 17 00:00:00 2001 From: Vladimir Razuvaev Date: Wed, 1 Sep 2021 21:23:39 +0700 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0af283259c24..c0c8c6aa5184 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ ### Fixes +- `[jest-util]` Return correct value from `process.send` stub ([#11799](https://github.com/facebook/jest/pull/11799)) + ### Chore & Maintenance ### Performance