From 1ebe96b07de49d9284927649ce329458c20789bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= Date: Mon, 6 Dec 2021 22:15:05 +0100 Subject: [PATCH 1/4] [jest-worker] Don't crash when running Node.js with flags not supported in workers --- packages/jest-worker/src/workers/NodeThreadsWorker.ts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/jest-worker/src/workers/NodeThreadsWorker.ts b/packages/jest-worker/src/workers/NodeThreadsWorker.ts index f28b834a5ee2..780f85dd2156 100644 --- a/packages/jest-worker/src/workers/NodeThreadsWorker.ts +++ b/packages/jest-worker/src/workers/NodeThreadsWorker.ts @@ -65,10 +65,6 @@ export default class ExperimentalWorker implements WorkerInterface { JEST_WORKER_ID: String(this._options.workerId + 1), // 0-indexed workerId, 1-indexed JEST_WORKER_ID }, eval: false, - // Suppress --max_old_space_size flags while preserving others (like --harmony). See https://nodejs.org/api/worker_threads.html#new-workerfilename-options - execArgv: process.execArgv.filter( - v => !/^--(max_old_space_size|max-old-space-size)/.test(v), - ), // @ts-expect-error: added in newer versions resourceLimits: this._options.resourceLimits, stderr: true, From 5f424178a2951a7ba1c00a45540933b6618d246d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= Date: Mon, 6 Dec 2021 21:42:33 +0000 Subject: [PATCH 2/4] Update test --- .../src/workers/__tests__/NodeThreadsWorker.test.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/jest-worker/src/workers/__tests__/NodeThreadsWorker.test.js b/packages/jest-worker/src/workers/__tests__/NodeThreadsWorker.test.js index 9e1d6500b104..1a4d04e57dba 100644 --- a/packages/jest-worker/src/workers/__tests__/NodeThreadsWorker.test.js +++ b/packages/jest-worker/src/workers/__tests__/NodeThreadsWorker.test.js @@ -54,12 +54,11 @@ afterEach(() => { it('passes fork options down to worker_threads.Worker, adding the defaults', () => { const thread = require.resolve('../threadChild'); - process.execArgv = ['--inspect', '-p']; - // eslint-disable-next-line no-new new Worker({ forkOptions: { execPath: 'hello', + execArgv: ['--inspect', '-p'] }, maxRetries: 3, workerData: { From 37db5f022d173fc1499a0426313fde54a52a85f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= Date: Mon, 6 Dec 2021 21:52:21 +0000 Subject: [PATCH 3/4] ESLint --- .../jest-worker/src/workers/__tests__/NodeThreadsWorker.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/jest-worker/src/workers/__tests__/NodeThreadsWorker.test.js b/packages/jest-worker/src/workers/__tests__/NodeThreadsWorker.test.js index 1a4d04e57dba..3ff5f2b6a874 100644 --- a/packages/jest-worker/src/workers/__tests__/NodeThreadsWorker.test.js +++ b/packages/jest-worker/src/workers/__tests__/NodeThreadsWorker.test.js @@ -57,8 +57,8 @@ it('passes fork options down to worker_threads.Worker, adding the defaults', () // eslint-disable-next-line no-new new Worker({ forkOptions: { + execArgv: ['--inspect', '-p'], execPath: 'hello', - execArgv: ['--inspect', '-p'] }, maxRetries: 3, workerData: { From 453d12d45b29ca40daac33a22489862a2d39d632 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Fri, 10 Dec 2021 05:28:07 +0100 Subject: [PATCH 4/4] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5aee1baba6b6..e12c317d499e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ ### Fixes - `[babel-jest]` Add `process.version` chunk to the cache key ([#12122](https://github.com/facebook/jest/pull/12122)) +- `[jest-worker]` Stop explicitly passing `execArgv` ([#12128](https://github.com/facebook/jest/pull/12128)) ### Chore & Maintenance