From 043092c631272f233259d2a1f4367f5d7ab903d6 Mon Sep 17 00:00:00 2001 From: Mihail Bodrov Date: Wed, 24 Apr 2019 01:25:52 +0300 Subject: [PATCH 1/3] [expect] optimize compare nodes :art: --- packages/expect/src/jasmineUtils.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/expect/src/jasmineUtils.ts b/packages/expect/src/jasmineUtils.ts index 3bf94b3cc3c8..a7f1cc35e44d 100644 --- a/packages/expect/src/jasmineUtils.ts +++ b/packages/expect/src/jasmineUtils.ts @@ -127,9 +127,8 @@ function eq( } var aIsDomNode = isDomNode(a); - var bIsDomNode = isDomNode(b); // Use DOM3 method isEqualNode (IE>=9) - if (aIsDomNode && typeof a.isEqualNode === 'function' && bIsDomNode) { + if (aIsDomNode && isDomNode(b)) { return a.isEqualNode(b); } From 9533e4cb22c1f67f67b75a28c46b559bad2e0c2d Mon Sep 17 00:00:00 2001 From: Mihail Bodrov Date: Thu, 25 Apr 2019 00:13:13 +0300 Subject: [PATCH 2/3] Remove needless varible --- packages/expect/src/jasmineUtils.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/expect/src/jasmineUtils.ts b/packages/expect/src/jasmineUtils.ts index a7f1cc35e44d..c3a9e70505a8 100644 --- a/packages/expect/src/jasmineUtils.ts +++ b/packages/expect/src/jasmineUtils.ts @@ -126,9 +126,8 @@ function eq( return false; } - var aIsDomNode = isDomNode(a); // Use DOM3 method isEqualNode (IE>=9) - if (aIsDomNode && isDomNode(b)) { + if (isDomNode(a) && isDomNode(b)) { return a.isEqualNode(b); } From f0f6fae8a2f86aac8b1ab9f1a66ee0ef0225c9d6 Mon Sep 17 00:00:00 2001 From: Mark Pedrotti Date: Sat, 27 Apr 2019 10:38:06 -0400 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0293346c3ae9..64cc33091f84 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,6 +30,7 @@ - `[docs]` Mention Jest MongoDB Preset ([#8318](https://github.com/facebook/jest/pull/8318)) - `[@jest/reporters]` Migrate away from `istanbul-api` ([#8294](https://github.com/facebook/jest/pull/8294)) - `[*]` Delete obsolete emails tag from header comment in test files ([#8377](https://github.com/facebook/jest/pull/8377)) +- `[expect]` optimize compare nodes ([#8368](https://github.com/facebook/jest/pull/8368)) ### Performance