From c6799c5da753f05f0c573840f0fbca0b67048306 Mon Sep 17 00:00:00 2001 From: Catherine Chanse Date: Tue, 3 Sep 2019 15:45:11 -0700 Subject: [PATCH 1/5] fix: Allow --testURL as a valid CLI option --- packages/jest-validate/src/validateCLIOptions.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/jest-validate/src/validateCLIOptions.ts b/packages/jest-validate/src/validateCLIOptions.ts index a10bd24ba8aa..a0bffad67a38 100644 --- a/packages/jest-validate/src/validateCLIOptions.ts +++ b/packages/jest-validate/src/validateCLIOptions.ts @@ -80,6 +80,7 @@ export default function validateCLIOptions( const unrecognizedOptions = Object.keys(argv).filter( arg => !allowedOptions.has(camelcase(arg)) && + !allowedOptions.has(arg) && (!rawArgv.length || rawArgv.includes(arg)), [], ); From 8b5f92649d9aff0781778ed2e10c8dcd16463c8f Mon Sep 17 00:00:00 2001 From: Catherine Chanse Date: Tue, 3 Sep 2019 15:59:23 -0700 Subject: [PATCH 2/5] chore: Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 84bcead3d743..d1aa103c480f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ ### Fixes +- `[jest-validate]` Allow --testURL as a CLI option ([#8889](https://github.com/facebook/jest/pull/8889)) - `[expect]` Display expectedDiff more carefully in toBeCloseTo ([#8389](https://github.com/facebook/jest/pull/8389)) - `[jest-fake-timers]` `getTimerCount` will not include cancelled immediates ([#8764](https://github.com/facebook/jest/pull/8764)) - `[jest-leak-detector]` [**BREAKING**] Use `weak-napi` instead of `weak` package ([#8686](https://github.com/facebook/jest/pull/8686)) From 8fba095cd112a68f0ee2ca1257cc06d337f60479 Mon Sep 17 00:00:00 2001 From: Catherine Chanse Date: Tue, 3 Sep 2019 16:17:20 -0700 Subject: [PATCH 3/5] fix: Correct CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d1aa103c480f..65740b30f99e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,7 +13,7 @@ ### Fixes -- `[jest-validate]` Allow --testURL as a CLI option ([#8889](https://github.com/facebook/jest/pull/8889)) +- `[jest-validate]` Allow --testURL as a CLI option ([#8908](https://github.com/facebook/jest/pull/8908)) - `[expect]` Display expectedDiff more carefully in toBeCloseTo ([#8389](https://github.com/facebook/jest/pull/8389)) - `[jest-fake-timers]` `getTimerCount` will not include cancelled immediates ([#8764](https://github.com/facebook/jest/pull/8764)) - `[jest-leak-detector]` [**BREAKING**] Use `weak-napi` instead of `weak` package ([#8686](https://github.com/facebook/jest/pull/8686)) From 22a89095e4a1968da12ec808466090850937388e Mon Sep 17 00:00:00 2001 From: Catherine Chanse Date: Wed, 11 Sep 2019 15:07:59 -0700 Subject: [PATCH 4/5] fix: Sort Changelog fix entries alphabetically --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 65740b30f99e..148f3d89fd53 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,13 +13,13 @@ ### Fixes -- `[jest-validate]` Allow --testURL as a CLI option ([#8908](https://github.com/facebook/jest/pull/8908)) - `[expect]` Display expectedDiff more carefully in toBeCloseTo ([#8389](https://github.com/facebook/jest/pull/8389)) - `[jest-fake-timers]` `getTimerCount` will not include cancelled immediates ([#8764](https://github.com/facebook/jest/pull/8764)) - `[jest-leak-detector]` [**BREAKING**] Use `weak-napi` instead of `weak` package ([#8686](https://github.com/facebook/jest/pull/8686)) - `[jest-mock]` Fix for mockReturnValue overriding mockImplementationOnce ([#8398](https://github.com/facebook/jest/pull/8398)) - `[jest-snapshot]` Remove only the added newlines in multiline snapshots ([#8859](https://github.com/facebook/jest/pull/8859)) - `[jest-snapshot]` Distinguish empty string from external snapshot not written ([#8880](https://github.com/facebook/jest/pull/8880)) +- `[jest-validate]` Allow --testURL as a CLI option ([#8908](https://github.com/facebook/jest/pull/8908)) ### Chore & Maintenance From 7e0f9706e7f267a2ea7b5f30df196f5b313b46d5 Mon Sep 17 00:00:00 2001 From: Catherine Chanse Date: Wed, 11 Sep 2019 15:11:53 -0700 Subject: [PATCH 5/5] fix: Add updated content from Changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 148f3d89fd53..35530adb2b88 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,8 @@ - `[jest-mock]` Fix for mockReturnValue overriding mockImplementationOnce ([#8398](https://github.com/facebook/jest/pull/8398)) - `[jest-snapshot]` Remove only the added newlines in multiline snapshots ([#8859](https://github.com/facebook/jest/pull/8859)) - `[jest-snapshot]` Distinguish empty string from external snapshot not written ([#8880](https://github.com/facebook/jest/pull/8880)) +- `[jest-snapshot]` [**BREAKING**] Distinguish empty string from internal snapshot not written ([#8898](https://github.com/facebook/jest/pull/8898)) +- `[jest-transform]` Properly cache transformed files across tests ([#8890](https://github.com/facebook/jest/pull/8890)) - `[jest-validate]` Allow --testURL as a CLI option ([#8908](https://github.com/facebook/jest/pull/8908)) ### Chore & Maintenance