From 8419551cf14edb4c8434a5c654e204a6f4c318e4 Mon Sep 17 00:00:00 2001 From: Ahn Date: Thu, 2 Apr 2020 14:09:38 +0200 Subject: [PATCH 1/3] chore(jest-types): correct return type of shouldRunTestSuite for JestHookEmitter --- CHANGELOG.md | 2 ++ packages/jest-watcher/src/types.ts | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 88e203693010..28b3d5629c1a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ ### Fixes +- `[@jest/watcher]` Correct return type of `shouldRunTestSuite` for `JestHookEmitter`. + ### Chore & Maintenance ### Performance diff --git a/packages/jest-watcher/src/types.ts b/packages/jest-watcher/src/types.ts index 4890c56b8f6e..cea9875965e7 100644 --- a/packages/jest-watcher/src/types.ts +++ b/packages/jest-watcher/src/types.ts @@ -36,7 +36,9 @@ export type JestHookSubscriber = { export type JestHookEmitter = { onFileChange: (fs: JestHookExposedFS) => void; onTestRunComplete: (results: AggregatedResult) => void; - shouldRunTestSuite: (testSuiteInfo: TestSuiteInfo) => Promise; + shouldRunTestSuite: ( + testSuiteInfo: TestSuiteInfo, + ) => Promise | boolean; }; export type UsageData = { From f8fe621c4f2dcde04b5661cbd95dfa56140e79af Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Thu, 2 Apr 2020 16:57:43 +0200 Subject: [PATCH 2/3] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 28b3d5629c1a..cb6e78ca5a2b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ ### Fixes -- `[@jest/watcher]` Correct return type of `shouldRunTestSuite` for `JestHookEmitter`. +- `[@jest/watcher]` Correct return type of `shouldRunTestSuite` for `JestHookEmitter` ([#9753](https://github.com/facebook/jest/pull/9753)) ### Chore & Maintenance From 1c43762fc93887f5f674fb38f6106f8212a5daea Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Thu, 2 Apr 2020 16:59:07 +0200 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cb6e78ca5a2b..3cf5560c5db9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,8 +3,7 @@ ### Features ### Fixes - -- `[@jest/watcher]` Correct return type of `shouldRunTestSuite` for `JestHookEmitter` ([#9753](https://github.com/facebook/jest/pull/9753)) +- `[@jest/watcher]` Correct return type of `shouldRunTestSuite` for `JestHookEmitter` ([#9753](https://github.com/facebook/jest/pull/9753)) ### Chore & Maintenance