Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup deployment template in chart #187

Open
hawksight opened this issue May 9, 2024 · 0 comments
Open

Cleanup deployment template in chart #187

hawksight opened this issue May 9, 2024 · 0 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@hawksight
Copy link

For example, remove comments and blank lines:

# Source: version-checker/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: version-checker
  labels:

    app.kubernetes.io/name: version-checker
    helm.sh/chart: version-checker-v0.5.4
    app.kubernetes.io/instance: version-checker
    app.kubernetes.io/version: "v0.5.4"
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: version-checker
      app.kubernetes.io/instance: version-checker
  template:
    metadata:
      labels:
        app.kubernetes.io/name: version-checker
        helm.sh/chart: version-checker-v0.5.4
        app.kubernetes.io/instance: version-checker
        app.kubernetes.io/version: "v0.5.4"
        app.kubernetes.io/managed-by: Helm
      annotations:
        prometheus.io/path: "/metrics"
        prometheus.io/scrape: "true"
        prometheus.io/port: "8080"
        enable.version-checker.io/version-checker: "true"
    spec:
      serviceAccountName: version-checker
      containers:
      - name: version-checker
        image: "quay.io/jetstack/version-checker:v0.5.4"
        imagePullPolicy: IfNotPresent
        ports:
        - name: metrics
          containerPort: 8080
        command: ["version-checker"]
        args:
          - "--image-cache-timeout=30m"
          - "--log-level=info"
          - "--metrics-serving-address=0.0.0.0:8080"
          - "--test-all-containers=true"
        resources:
            {}
        livenessProbe:
          httpGet:
            path: /readyz
            port: 8080
          initialDelaySeconds: 3
          periodSeconds: 3
        readinessProbe:
          httpGet:
            path: /readyz
            port: 8080
          initialDelaySeconds: 3
          periodSeconds: 3
        env:
        # ACR

        # ECR

        # Docker

        # GCR

        # GHCR

        # Quay

        # Selfhosted


      volumes:
@hawksight hawksight added the good first issue Good for newcomers label May 9, 2024
@davidcollom davidcollom added this to the v1 release milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants