Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's a problem with the latest tag fetch logic for some of the mirrored tags. #52

Open
JaeGerW2016 opened this issue Sep 30, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@JaeGerW2016
Copy link

Like docker.io/coredns/coredns
20200930154004.jpg

@JoshVanL
Copy link
Contributor

Thanks @JaeGerW2016,

So I can reproduce the issue, can you confirm whether there are any search options present on the pod annotations?
These being the ones from this list

/assign

@JoshVanL
Copy link
Contributor

Had a quick look and looks like I have found the issue. The cordns registry on docker.io has these tags available.

api.ImageTag{Tag:"011", SHA:"sha256:d3596431680bfa0220599c11f59d4c567408ac21af57d9ec6f2328f0bea8fd46", Timestamp:time.Time{wall:0x1a71c298, ext:63640665398, loc:(*time.Location)(nil)}, Architecture:"amd64", OS:"linux"}
api.ImageTag{Tag:"007", SHA:"sha256:b010831452297a91ede477429d93371aad2c18a3c75b977eb1c60535f27dbd9f", Timestamp:time.Time{wall:0x2fa5f7b0, ext:63636779675, loc:(*time.Location)(nil)}, Architecture:"amd64", OS:"linux"}
api.ImageTag{Tag:"006", SHA:"sha256:45772ece0316b989bac28d4d8be0fb7d05f7455f38b3221590417a07abe10208", Timestamp:time.Time{wall:0x11db4a00, ext:63636681305, loc:(*time.Location)(nil)}, Architecture:"amd64", OS:"linux"}
api.ImageTag{Tag:"010", SHA:"sha256:b86904e36dd0a567155669131f2c5129fbcf3b0d3ae7640f52f3d62256eebc08", Timestamp:time.Time{wall:0x4ff2cc0, ext:63636679588, loc:(*time.Location)(nil)}, Architecture:"amd64", OS:"linux"}
api.ImageTag{Tag:"008", SHA:"sha256:b13367ea8432f8528b2e5ff224cff9b9120fc9069fcc1c99c133b7951c819979", Timestamp:time.Time{wall:0x6687120, ext:63636675921, loc:(*time.Location)(nil)}, Architecture:"amd64", OS:"linux"}
api.ImageTag{Tag:"009", SHA:"sha256:3114cd283a764582e8e8230a2b233b6fa31efccc2448a3400ad3f2fa50406525", Timestamp:time.Time{wall:0x1a4ee4d0, ext:63636675897, loc:(*time.Location)(nil)}, Architecture:"amd64", OS:"linux"}

Since authors can choose to host images which do not follow their semvar, there are a number of options we can use to prevent these tags being considered in our search. I would recommend setting the following annotation on your coredns pods (replacing the container name if it is different).

match-regex.version-checker.io/coredns: ^v?\d+.\d+.\d+$

This will ensure that only tags which have the form of something like 1.2.3 or v4.5.6 will be considered.

@JoshVanL
Copy link
Contributor

/unassign
/assign @JaeGerW2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants