Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #11709 fix jetty-with-custom-class.xml file and use it #11716

Merged
merged 2 commits into from May 3, 2024
Merged

Issue #11709 fix jetty-with-custom-class.xml file and use it #11716

merged 2 commits into from May 3, 2024

Conversation

janbartel
Copy link
Contributor

Fixes #11709

Also fix:

  • jetty osgi logging
  • ensure DeploymentManager is configured
  • re-instate test that uses jetty-with-custom-class.xml file

@janbartel janbartel self-assigned this Apr 29, 2024
@janbartel janbartel requested a review from olamy April 29, 2024 06:58
@janbartel
Copy link
Contributor Author

@olamy bump

olamy
olamy previously approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just some nit comments)

jetty-core/jetty-osgi/src/main/java/org/eclipse/jetty/osgi/JettyServerFactory.java Outdated Show resolved Hide resolved
jetty-ee10/jetty-ee10-osgi/test-jetty-ee10-osgi/pom.xml Outdated Show resolved Hide resolved
jetty-ee10/jetty-ee10-osgi/test-jetty-ee10-osgi/pom.xml Outdated Show resolved Hide resolved
@janbartel janbartel requested a review from olamy May 2, 2024 01:54
@janbartel
Copy link
Contributor Author

@olamy suggested changes made - can you give me another review so I can merge??

@janbartel janbartel merged commit b11d1cb into jetty-12.0.x May 3, 2024
10 checks passed
@janbartel janbartel deleted the jetty-12.0.x-11709-jetty-with-custom-class-xml branch May 3, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

Assignees

@janbartel janbartel

Labels
None yet
Projects
Jetty 12.0.10
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test-jetty-ee9-osgi file jetty-with-custom-class.xml references an ee10 class
2 participants
@janbartel @olamy