Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: optional KUMI_HOST_DEVICE macro for CUDA #54

Open
leha-bot opened this issue Mar 11, 2023 · 2 comments
Open

feature request: optional KUMI_HOST_DEVICE macro for CUDA #54

leha-bot opened this issue Mar 11, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@leha-bot
Copy link

leha-bot commented Mar 11, 2023 •
edited

Hello, it would be great if kumi would support the CUDA __host__ __device__`` specifiers as an opt-in feature under the KUMI_ENABLE_CUDA_SUPPORT` CMake option.
Won't mind if I propose a PR with this feature?

Thanks in advance.
@jfalcou
Copy link
Owner

jfalcou commented Mar 11, 2023

Sounds good, feel free to PR !

@jfalcou
Copy link
Owner

jfalcou commented Mar 11, 2023

But do we need the macro, can't we just detect cusa and change the macro meaning ?

@jfalcou jfalcou added the enhancement New feature or request label Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfalcou @leha-bot