Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable error-prone FallThrough test #239

Open
regisd opened this issue Nov 4, 2017 · 1 comment · May be fixed by #364
Open

Enable error-prone FallThrough test #239

regisd opened this issue Nov 4, 2017 · 1 comment · May be fixed by #364
Assignees
@regisd
Labels
code quality Code health and clean-up
Projects
Continuous integration

Comments

@regisd
Copy link
Member

regisd commented Nov 4, 2017

In v. 1.7.0 the generated code doesn't have FallThrough violations anymore (see #222).

Re-enable the test as an error (currently downgraded as warning)
@regisd regisd added the code quality Code health and clean-up label Nov 4, 2017
@regisd regisd added this to the 1.7.1 milestone Nov 4, 2017
@regisd regisd self-assigned this Nov 4, 2017
@regisd regisd modified the milestones: 1.7.1, 1.8.0 Sep 18, 2018
regisd added a commit that referenced this issue Sep 22, 2018
@regisd
Re-enable check against FallThrough violations
00a7dd2 
Fix #239
@regisd regisd linked a pull request Sep 22, 2018 that will close this issue
Draft
@regisd
Copy link
Member Author

regisd commented Sep 22, 2018

Actually, the generated code is still not conformant

/home/travis/build/jflex-de/jflex/jflex/target/generated-sources/jflex/jflex/LexScan.java:2550: error: [FallThrough] Execution may fall through from the previous case; add a `// fall through` comment before this line if it was deliberate
            case 799: break;
            ^
    (see http://errorprone.info/bugpattern/FallThrough)

https://travis-ci.org/jflex-de/jflex/jobs/431900782

@regisd regisd removed this from the 1.8.0 milestone Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@regisd regisd

Labels
code quality Code health and clean-up
Projects
Continuous integration
  
TODO
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable check against FallThrough violations jflex-de/jflex
1 participant
@regisd