Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encrypt & decrypt build info properties file #766

Merged
merged 9 commits into from
Dec 3, 2023
Merged

Encrypt & decrypt build info properties file #766

merged 9 commits into from
Dec 3, 2023

Conversation

Or-Geva
Copy link
Collaborator

@Or-Geva Or-Geva commented Nov 21, 2023 •
edited

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

This pull request introduces additional APIs dedicated to the encryption and decryption of the build information properties file.

@Or-Geva Or-Geva added the improvement Automatically generated release notes label Nov 21, 2023
@Or-Geva Or-Geva requested a review from yahavi November 21, 2023 19:29
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Nov 21, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 21, 2023
@Or-Geva Or-Geva changed the title Encrypted & decrypt build info properties file Encrypt & decrypt build info properties file Nov 21, 2023
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Nov 21, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 21, 2023
@Or-Geva Or-Geva mentioned this pull request Nov 22, 2023
Merged
3 tasks
yahavi
yahavi requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Due to the sensitivity of the encryption algorithm, I'd like to review it again once the comments are handled.

.../main/java/org/jfrog/build/extractor/clientConfiguration/ArtifactoryClientConfiguration.java Outdated Show resolved Hide resolved
.../main/java/org/jfrog/build/extractor/clientConfiguration/ArtifactoryClientConfiguration.java Outdated Show resolved Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/BuildInfoExtractorUtils.java Show resolved Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/BuildInfoExtractorUtils.java Outdated Show resolved Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/BuildInfoExtractorUtils.java Outdated Show resolved Hide resolved
@Or-Geva Or-Geva requested a review from yahavi November 28, 2023 19:15
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Nov 28, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 28, 2023
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Nov 29, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 29, 2023
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Nov 29, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 29, 2023
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Nov 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 30, 2023
yahavi
yahavi requested changes Nov 30, 2023
View reviewed changes
...in/java/org/jfrog/build/extractor/clientConfiguration/util/encryption/EncryptionKeyPair.java Outdated Show resolved Hide resolved
...in/java/org/jfrog/build/extractor/clientConfiguration/util/encryption/EncryptionKeyPair.java Show resolved Hide resolved
...in/java/org/jfrog/build/extractor/clientConfiguration/util/encryption/EncryptionKeyPair.java Outdated Show resolved Hide resolved
...rg/jfrog/build/extractor/clientConfiguration/util/encryption/SecurePropertiesEncryption.java Outdated Show resolved Hide resolved
...rg/jfrog/build/extractor/clientConfiguration/util/encryption/SecurePropertiesEncryption.java Outdated Show resolved Hide resolved
...rg/jfrog/build/extractor/clientConfiguration/util/encryption/SecurePropertiesEncryption.java Outdated Show resolved Hide resolved
...rg/jfrog/build/extractor/clientConfiguration/util/encryption/SecurePropertiesEncryption.java Outdated Show resolved Hide resolved
...rg/jfrog/build/extractor/clientConfiguration/util/encryption/SecurePropertiesEncryption.java Outdated Show resolved Hide resolved
build-info-extractor/src/test/java/org/jfrog/build/extractor/BuildExtractorUtilsTest.java Outdated Show resolved Hide resolved
...rg/jfrog/build/extractor/clientConfiguration/util/encryption/SecurePropertiesEncryption.java Outdated Show resolved Hide resolved
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Nov 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 30, 2023
@Or-Geva Or-Geva requested a review from yahavi November 30, 2023 21:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

yahavi
yahavi approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Or-Geva Or-Geva merged commit ca03eac into jfrog:master Dec 3, 2023
30 checks passed
@afolgado
Copy link

Hi,
I'm not sure if this is the right place to ask this, but since this feature was implemented I always get the following error when building Maven projects, so I can't update beyond 4.0.0:

org.apache.maven.InternalErrorException: Internal error: java.lang.RuntimeException: Unable to load build info properties from file:[...]@tmp/artifactory/buildInfo4665447417566822634.properties
Caused by: java.security.InvalidKeyException: Illegal key size

Any ideas why this is happening?

@yahavi
Copy link
Member

yahavi commented May 15, 2024

@afolgado,
Could you kindly open an issue on https://github.com/jfrog/jenkins-artifactory-plugin with as much detail as possible? Appreciate it!

@afolgado afolgado mentioned this pull request May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Or-Geva @afolgado @yahavi