Skip to content

Reduce package size by adding "files" field to package.json #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

FujiHaruka
Copy link
Contributor

I greatly appreciate this great and simple library you developed to join URLs.

Because your library is so famous and so many installed, it would be nice if the package size gets smaller.

This PR just suggests to reduce the package size by adding "files" field to package.json

This change will make the package size smaller.

I checked how effective it is by comparing the sizes as following.

Without "files" field: 18.3 kB

$ npm publish --dry-run 2>&1 | grep "unpacked size"
npm notice unpacked size: 18.3 kB

With "files" field: 4.8 kB

$ npm publish --dry-run 2>&1 | grep "unpacked size"
npm notice unpacked size: 4.8 kB

Thank you.

FujiHaruka and others added 2 commits November 28, 2021 14:26

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jonkoops jonkoops merged commit be56f57 into jfromaniello:main Mar 23, 2022
@jonkoops
Copy link
Collaborator

Great addition, thanks for your contribution @FujiHaruka!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants