Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File picker fails on open, save, and export #706

Closed
2 tasks done
wwitzke opened this issue Sep 15, 2021 · 26 comments
Closed
2 tasks done

File picker fails on open, save, and export #706

wwitzke opened this issue Sep 15, 2021 · 26 comments
Assignees
Labels
blocked/upstream Blocked on upstream dependency

Comments

@wwitzke
Copy link

wwitzke commented Sep 15, 2021

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
When I attempt to open, save, or export a file using drawio-desktop, the file picker fails to open. When I have started the application from the command line, I see the following:
[5036:0915/171552.752134:ERROR:browser_main_loop.cc(269)] Gtk: gtk_native_dialog_run: assertion '!priv->visible' failed
In every case, I see the file picker briefly, but it disappears. Note that the file picker does not open under the main drawio window, it either fails to open or to stay open.

To Reproduce
Steps to reproduce the behavior:

  1. Start drawio (preferably from the command line)
  2. Go to File > Open

Or:

  1. Start drawio
  2. Add an element to the drawing
  3. Go to File > Save As...

Expected behavior
The file picker opens, I am able to select a file and open it, or the file picker opens, I am able to name/rename the drawing and save it.

draw.io version (In the Help->About menu of the draw.io editor):

  • 5.2.7

Desktop (please complete the following information):

  • OS: xubuntu 20.04.3

Additional context
I updated today. This did not happen in the previous version of drawio I was using (14.9.6)

@alishir
Copy link

alishir commented Sep 16, 2021

I have the same problem on Debian 11.0 with drawio 15.2.7.

@aszswaz
Copy link

aszswaz commented Sep 16, 2021

I have the same problem on manjaro linux, even the window does not flash.
I guess the reason is electron, or the Chromium version embedded in electron is too old. This log indicates that the error comes from the GTK framework used by the embedded Chromium. The old GTK and the latest X11 have compatibility issues.
The browser I use is Chromium, which is the latest version, and it runs well on my computer.
Lovely developers, it’s time to update electron.

@davidjgraph
Copy link
Contributor

5.2.7 is Electron 14, what is it you're suggesting to update to?

@aszswaz
Copy link

aszswaz commented Sep 16, 2021

5.2.7 is Electron 14, what is it you're suggesting to update to?

Okay, I think I should go to the electron side to check it out.

@wwitzke
Copy link
Author

wwitzke commented Sep 17, 2021

If what @aszswaz is saying is true, wouldn't that mean that older versions of drawio-desktop would also be having this problem? I don't have any trouble getting the file picker windows to open in version 14.9.6. Do older versions of drawio-desktop use a newer version of the GTK framework (for some reason)?

@wwitzke
Copy link
Author

wwitzke commented Sep 17, 2021

I also just tried version 15.1.3 and 15.2.5. The problem does not appear in 15.1.3, but does in 15.2.5.

@keypey

This comment has been minimized.

@aszswaz
Copy link

aszswaz commented Sep 17, 2021

If what @aszswaz is saying is true, wouldn't that mean that older versions of drawio-desktop would also be having this problem? I don't have any trouble getting the file picker windows to open in version 14.9.6. Do older versions of drawio-desktop use a newer version of the GTK framework (for some reason)?

This is just my guess, in fact I found that this may not be a problem with the old version. Instead, it may be caused by the new version of eletron. My other application, typora, based on eletron, also has a bug that cannot drag files, which has never appeared in previous versions.

@ferrolho
Copy link

Hi! I am using Ubuntu 20.04.3 and I also have this issue on versions 15.2.5--15.2.7. Version 15.1.3 is the most recent release where this is not a problem.

@davidjgraph davidjgraph added the blocked/upstream Blocked on upstream dependency label Sep 21, 2021
@Nimelrian
Copy link

Chiming in, Manjaro with i3 as WM, draw.io version 15.2.7.

@davidjgraph
Copy link
Contributor

Thanks for all the feedback. It's an upstream issue on Electron, we'll build on new releases as they come out on stable.

@jethrogb
Copy link

What's the upstream ticket?

@chicolucio
Copy link

chicolucio commented Sep 24, 2021

Same problem on Linux Mint 19.3 using version 15.2.7

edit: works normally downgrading to 15.1.3

@argenos
Copy link

argenos commented Sep 27, 2021

Same issue on Ubuntu 18.04 with v15.2.7. Do we know which is the upstream issue that needs to be tracked? It would help manage expectations on the ETA for this fix, since we're waiting for an upstream fix to make it to stable (which in my experience can take some time).

@davidjgraph
Copy link
Contributor

We believe it's electron/electron#30927, which is fixed. Our release candidates are built, if anyone wants to test a specific build, let me know which.

@ferrolho
Copy link

I can test the Linux DEB file. Where can I find it?

@davidjgraph
Copy link
Contributor

@ferrolho
Copy link

Unfortunately, the issue is still present.

@yurayko
Copy link

yurayko commented Sep 27, 2021

(Debian 11, drawio 15.3.5) Run from terminal. After click 'File -> Open' I see message on terminal:
14041:0927/161434.457553:ERROR:browser_main_loop.cc(269)] Gtk: gtk_native_dialog_run: assertion '!priv->visible' failed

@nurgasemetey
Copy link

Same for (Linux Mint 20.2, drawio 15.3.5, AppImage)

[698488:0927/174047.536924:ERROR:sandbox_linux.cc(374)] InitializeSandbox() called with multiple threads in process gpu-process.
17:40:47.574 › Checking for update
17:40:48.467 › Update for version 15.3.5 is not available (latest version: 15.3.5, downgrade is disallowed).
[698450:0927/174059.055590:ERROR:browser_main_loop.cc(269)] Gtk: gtk_native_dialog_run: assertion '!priv->visible' failed
[698450:0927/174102.972435:ERROR:browser_main_loop.cc(269)] Gtk: gtk_native_dialog_run: assertion '!priv->visible' failed

@davidjgraph davidjgraph added this to Triage in drawio-desktop via automation Sep 27, 2021
@davidjgraph davidjgraph moved this from Triage to Todo - Low Priority in drawio-desktop Sep 27, 2021
@neonoxd
Copy link

neonoxd commented Sep 28, 2021

Fedora 34, 15.3.5-beta, the issue is still present
[590022:0928/173942.262107:ERROR:browser_main_loop.cc(269)] Gtk: gtk_native_dialog_run: assertion '!priv->visible' failed

@davidjgraph
Copy link
Contributor

We've done a 15.3.7. This reverts to Electron 14, but I suspect it have the same problem.

If it does, we'll remove all Linux releases after 15.1.3, so people don't update beyond that. We'll try to work out what is happening, in the meantime.

@jethrogb
Copy link

jethrogb commented Sep 28, 2021

Just tested on Ubuntu 20.04, issue remains on 15.3.7

@davidjgraph
Copy link
Contributor

Thanks for checking, we'll pull the incorrect releases now. Please all revert to 15.1.3, thanks for your patience.

@davidjgraph
Copy link
Contributor

davidjgraph commented Sep 28, 2021

electron/electron#31152 looks like the correct upstream. Please vote for the issue (thumbs up the original post).

@davidjgraph
Copy link
Contributor

We reverted to Electron 13.4.0 in 15.3.8 to avoid this issue.

drawio-desktop automation moved this from Todo - Low Priority to Done Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/upstream Blocked on upstream dependency
Projects
Development

No branches or pull requests