Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offsets do not work in rtl #3005

Closed
CertainlyAria opened this issue Jun 19, 2020 · 3 comments
Closed

offsets do not work in rtl #3005

CertainlyAria opened this issue Jun 19, 2020 · 3 comments
Assignees
@jgthms
Labels
rtl

Comments

@CertainlyAria
Copy link

This is a bug about Bulma rtl.

Overview of the problem

I'm using Bulma version 0.9.0
My browser is: Google Chrome v83
$rtl: true is set.
I tested this both with webpack and bulma rtl cdn (this one to be precise )

Description

I face this bug when page direction is rtl. Basically offsets do not work with rtl pages.
I have this class on my column:
column is-half is-offset-one-quarter
But page displays like this:
bulma_rtl

When I switch page direction back to ltr (with <html dir="ltr"> page displays correctly:
bulma_ltr

And here is my html body
@CertainlyAria
Copy link
Author

I found out that classes like offset-one-quarter always add margin to left (margin-left: 25%;), if direction is rtl they should add margin-right: 25%;

@OrGalili
Copy link

bulma-rtl.css in field-label class (line 4370), value of text-align property should be left I think.

@mhf-ir
Copy link

mhf-ir commented Aug 15, 2020

Same problem,
https://codepen.io/mhf-ir/pen/YzqqZBy

margin-left: shoud be margin-right

@jgthms jgthms self-assigned this Aug 15, 2020
@jgthms jgthms added the rtl label Aug 15, 2020
@Tofandel Tofandel mentioned this issue Aug 16, 2020
Closed
@jgthms jgthms mentioned this issue Oct 7, 2020
Closed
@jgthms jgthms closed this as completed in bd1b032 Oct 7, 2020
This was referenced May 24, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgthms jgthms

Labels
rtl
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mhf-ir @jgthms @OrGalili @CertainlyAria