Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single file for extends #3216

Merged
merged 3 commits into from
Dec 20, 2020
Merged

Use single file for extends #3216

merged 3 commits into from
Dec 20, 2020

Conversation

jgthms
Copy link
Owner

@jgthms jgthms commented Dec 20, 2020

This is a bugfix.

Proposed solution

Instead of importing the mixins file which also includes all Sass placeholders, move all placeholders to its own extends file, and import that file only once.

Also, all references to the .sass file extension have been removed, since they're unnecessary when there's no ambiguity between a .sass file or a .scss file.

Tradeoffs

If you imported mixins to get the placeholders, you need to include extends instead.
If you imported using .sass, you'll need to remove it now.

Testing Done

Imported Bulma in custom setups. Still works.

Changelog updated?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant